Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2698716ybp; Sat, 5 Oct 2019 18:22:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqw2+5/9DIlf/BbgxO347jMsWHUUCaD8Vpdcfe9n01vL50oNMhSMlbyRnkZnzgMSaci2Jp1Z X-Received: by 2002:a17:906:3286:: with SMTP id 6mr18332576ejw.37.1570324971469; Sat, 05 Oct 2019 18:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570324971; cv=none; d=google.com; s=arc-20160816; b=gI8kSTE695obg77l0PjLT6fKeyTe7u/41qpsy4z5z9wt9zlb+6aDzbzMmjT8S9Iy2J wvhEEAr2vGrAmFnT3biSo4O+CzgDVfo2qmGMxJxe/zH4rRXDwAdzow8/PEUL5HC+4GuM W2qEhVju9tY+M8xB0uzWew9N4QecTF752DsZTxpYY712qwTvqHVK0hzMsVOqDB17hDCJ LQA6IIUAtznN1wTgSiDhCq7yXOnnsHrJZsGp6df1fAFuZM45lEsWvnCIONkzt3zIiUJ3 ELqRBkaA5kRU6fVzXBGzKMv8Dfz+SYpkopb/YwOlR1h52AmI0ycgTPsYONiht1xmjst0 i+Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eQtBxf6YeT/ssyGmskPYndGl2Ycourj9/DvbgzOooHc=; b=U3gN4VK6zUsCipawH2e/+k67X6GwbnkQNgH/FfoLUrdCV1tuB4phKi/A4QC5YPPJ1I ewPXgJoXw0FDvEMobD7b7KXl2L/Gx/DY75HwAWsyPBe3mSO5V6YIW6M8ucsMjF0YIpFg OHSWcDsdoKTfHJpNwztM4JQOVGuoYB3yaM+umBV/nY9RImgyWKtmJN22a7ihonz6I6Js Mdd7oafP77VEngImx8kVyZfzoPtWBmqyne24hyWmLQROTCZiiEIri2JtqDHs1U7ediRG EryIXPnPAcVVPxTC5IFRXMUhepgbSeOijISZZ8BQ0YY77ycA5eaWVnizv2uuVslq7TlW qwkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tKSRDosi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d23si6233493edb.55.2019.10.05.18.22.27; Sat, 05 Oct 2019 18:22:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tKSRDosi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbfJFBWK (ORCPT + 99 others); Sat, 5 Oct 2019 21:22:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:51946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726956AbfJFBWJ (ORCPT ); Sat, 5 Oct 2019 21:22:09 -0400 Received: from dragon (li937-157.members.linode.com [45.56.119.157]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84B3A222C8; Sun, 6 Oct 2019 01:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570324929; bh=lg1rcaPaYzlWfGFd7qFkTdrWx6pX1IzDsEq3GfuVM7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tKSRDosiWc8MJ8AXoLQ4RxgA03z9u8Yw/Mbw9HgGxtf+SR359QrHrFv5dG332rVLh rcNM/S4ZtrviI1Kjak/neKKCbN2JsuXaLNiTIgzaa6N4Mt78oYPERAX1oHpmBvVY9G ePT4hYVqeBXGDU6yEJga2m5VXaHZ7DI4UiahDyF8= Date: Sun, 6 Oct 2019 09:21:51 +0800 From: Shawn Guo To: Anson Huang Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, daniel.baluta@nxp.com, aisheng.dong@nxp.com, abel.vesa@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] soc: imx: imx-scu: Getting UID from SCU should have response Message-ID: <20191006012149.GI7150@dragon> References: <1567624394-25023-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567624394-25023-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 04, 2019 at 03:13:14PM -0400, Anson Huang wrote: > The SCU firmware API for getting UID should have response, > otherwise, the message stored in function stack could be > released and then the response data received from SCU will be > stored into that released stack and cause kernel NULL pointer > dump. > > Fixes: 73feb4d0f8f1 ("soc: imx-scu: Add SoC UID(unique identifier) support") > Signed-off-by: Anson Huang Applied, thanks.