Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2805701ybp; Sat, 5 Oct 2019 21:25:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLDjxLQZEUVq1revH881KSV0VwDdq/PwmMnbm9GAmODmRScQFf2PMCRAJZKTw0rgoW8n5B X-Received: by 2002:a17:906:564b:: with SMTP id v11mr18364302ejr.225.1570335904094; Sat, 05 Oct 2019 21:25:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570335904; cv=none; d=google.com; s=arc-20160816; b=aRyQIxMGyOaP8pqUyx21938O2dqgTE3vaRe62uBbFKG8rnM7+ig37jzWSomTcPj6T+ G+AQJKIrFgAktT7EGEnjWlqYDu6iUtVmgV97JCtqvoRLzIM8N+M+dkx9MKelgEwPb7A4 xCBiZOBOd2Fyql+gGf9vuxObVC2GvOxcMD3LtuR/jY6JMdNNRBI4yZd1tUSJgtnfnSkW sGrNpEShreAb1lsyEpnDWV53F/6CQnEbVTIRQmy1OygdXhbBACw36FnL+VR+HClo0YjE VxLO+Y8QuGkiOBRMiUHv7Ln/DO4rSBtuK7VlvaALeZwsvnjaBFzDlF0WPIjAxmzLLQ8N wtiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=gucj+g4EoHDMR3Qjq+W+/KnRt4GIm4ma7IFGDoymLCM=; b=Z7KyApNUpVLJdhEJhIcHi2fPzfOoK8exGQy0+ql3ENekbwFl3SrBncy7ro7wF72+Lf HYfviEDyMc9hOTXqhc7vjDp2LR4Mx/n9SyaZssc0GbVG1iU0k7+b6n3reKMhPx+WmcrO AW+0AKl4aP1mK5HMvL6dskdYfNmtaKmEq2Bh17gbbDqB+trJpHrPXx16yuD6vGDoSH0Z t5rVm5QKTDcH3rVyFlnz6b35wfHwVv8Bu+EAP+zfMK8nWDYxss4FS3Y2L6Qdf/nvWJKc JmhrmsHQvUobn+W0m5Jjp4pG3W3y/NFee647vbt3yE5bwVK9ZankktBIkEWV9VAJtyg0 lZYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14si6561435eda.104.2019.10.05.21.24.38; Sat, 05 Oct 2019 21:25:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726109AbfJFEX1 (ORCPT + 99 others); Sun, 6 Oct 2019 00:23:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3248 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726086AbfJFEX0 (ORCPT ); Sun, 6 Oct 2019 00:23:26 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CFB20F71EDA02A3BA95B; Sun, 6 Oct 2019 12:23:23 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Sun, 6 Oct 2019 12:23:20 +0800 Subject: Re: [RFC PATCH] scripts: Fix coccicheck failed To: Masahiro Yamada , Julia Lawall References: <20190928094245.45696-1-yuehaibing@huawei.com> <2c109d6b-45ad-b3ca-1951-bde4dac91d2a@huawei.com> CC: Gilles Muller , Nicolas Palix , Michal Marek , "Matthias Maennich" , Greg Kroah-Hartman , Linux Kernel Mailing List , Coccinelle From: Yuehaibing Message-ID: <490422f5-e33f-3aab-ba2d-747b9fecca91@huawei.com> Date: Sun, 6 Oct 2019 12:23:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/4 10:32, Masahiro Yamada wrote: > On Thu, Oct 3, 2019 at 9:23 PM Julia Lawall wrote: >> >> >> >> On Thu, 3 Oct 2019, Masahiro Yamada wrote: >> >>> On Tue, Oct 1, 2019 at 10:01 PM Julia Lawall wrote: >>>>> diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/coccinelle/misc/add_namespace.cocci >>>>> index c832bb6445a8..99e93a6c2e24 100644 >>>>> --- a/scripts/coccinelle/misc/add_namespace.cocci >>>>> +++ b/scripts/coccinelle/misc/add_namespace.cocci >>>>> @@ -6,6 +6,8 @@ >>>>> /// add a missing namespace tag to a module source file. >>>>> /// >>>>> >>>>> +virtual report >>>>> + >>>>> @has_ns_import@ >>>>> declarer name MODULE_IMPORT_NS; >>>>> identifier virtual.ns; >>>>> >>>>> >>>>> >>>>> Adding virtual report make the coccicheck go ahead smoothly. >>>> >>>> Acked-by: Julia Lawall >>>> >>> >>> >>> Was this patch posted somewhere? >> >> It was probably waiting for moderation in the cocci mailing list. Do you >> have it now (or in a few minutes)? > > No. I do not see it yet. > > I want to pick the patch from LKML Patchwork > https://lore.kernel.org/patchwork/project/lkml/list/ > > You gave Acked-by to the one-liner fix "virtual report", > and I am happy to apply it to my tree. > > YueHaibing, could you submit it as a patch? Sorry for late, will send it. > >