Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; 
  b=cDwV6hb+NyGC8VSO2EZ+EmtGX5BMCkpwJ1O8GBJzbxkyT0cWSmisM3+/O6urqWb2jEsRxpA83W/b
    Im3x1rkqZvI9vu7bBda3p9ZD3nWC9f3tnDRbFbJnLFjMpBklniCm  
Subject: Re: [PATCH 1/5 v5] irqchip: ingenic: Drop redundant irq_suspend /
 irq_resume functions
To:     Paul Cercueil <paul@crapouillou.net>
References: <1548517123-60058-1-git-send-email-zhouyanjie@zoho.com>
 <1570015525-27018-1-git-send-email-zhouyanjie@zoho.com>
 <1570015525-27018-2-git-send-email-zhouyanjie@zoho.com>
 <1570320829.3.2@crapouillou.net>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, paul.burton@mips.com,
        gregkh@linuxfoundation.org, jason@lakedaemon.net, syq@debian.org,
        marc.zyngier@arm.com, rfontana@redhat.com, armijn@tjaldur.nl,
        allison@lohutok.net
From:   Zhou Yanjie <zhouyanjie@zoho.com>
Message-ID: <5D99832E.5060505@zoho.com>
Date:   Sun, 6 Oct 2019 14:01:18 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1570320829.3.2@crapouillou.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Pual,

On 2019=E5=B9=B410=E6=9C=8806=E6=97=A5 08:13, Paul Cercueil wrote:
> Hi Zhou,
>
>
> Le mer., oct. 2, 2019 at 19:25, Zhou Yanjie <zhouyanjie@zoho.com> a=20
> =C3=A9crit :
>> From: Paul Cercueil <paul@crapouillou.net>
>>
>> The same behaviour can be obtained by using the IRQCHIP_MASK_ON_SUSPEND
>> flag on the IRQ chip.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>
> If you sumbit a patchset that contains someone else's patches you need=20
> to add your Signed-off-by too.

Thank you for the reminder. I'll add my Signed-off-by in v6.
>
>> ---
>>  drivers/irqchip/irq-ingenic.c   | 24 +-----------------------
>>  include/linux/irqchip/ingenic.h | 14 --------------
>>  2 files changed, 1 insertion(+), 37 deletions(-)
>>  delete mode 100644 include/linux/irqchip/ingenic.h
>>
>> diff --git a/drivers/irqchip/irq-ingenic.c=20
>> b/drivers/irqchip/irq-ingenic.c
>> index f126255..06fa810 100644
>> --- a/drivers/irqchip/irq-ingenic.c
>> +++ b/drivers/irqchip/irq-ingenic.c
>> @@ -10,7 +10,6 @@
>>  #include <linux/interrupt.h>
>>  #include <linux/ioport.h>
>>  #include <linux/irqchip.h>
>> -#include <linux/irqchip/ingenic.h>
>>  #include <linux/of_address.h>
>>  #include <linux/of_irq.h>
>>  #include <linux/timex.h>
>> @@ -50,26 +49,6 @@ static irqreturn_t intc_cascade(int irq, void *data)
>>      return IRQ_HANDLED;
>>  }
>>
>> -static void intc_irq_set_mask(struct irq_chip_generic *gc, uint32_t=20
>> mask)
>> -{
>> -    struct irq_chip_regs *regs =3D &gc->chip_types->regs;
>> -
>> -    writel(mask, gc->reg_base + regs->enable);
>> -    writel(~mask, gc->reg_base + regs->disable);
>> -}
>> -
>> -void ingenic_intc_irq_suspend(struct irq_data *data)
>> -{
>> -    struct irq_chip_generic *gc =3D irq_data_get_irq_chip_data(data);
>> -    intc_irq_set_mask(gc, gc->wake_active);
>> -}
>> -
>> -void ingenic_intc_irq_resume(struct irq_data *data)
>> -{
>> -    struct irq_chip_generic *gc =3D irq_data_get_irq_chip_data(data);
>> -    intc_irq_set_mask(gc, gc->mask_cache);
>> -}
>> -
>>  static struct irqaction intc_cascade_action =3D {
>>      .handler =3D intc_cascade,
>>      .name =3D "SoC intc cascade interrupt",
>> @@ -127,8 +106,7 @@ static int __init ingenic_intc_of_init(struct=20
>> device_node *node,
>>          ct->chip.irq_mask =3D irq_gc_mask_disable_reg;
>>          ct->chip.irq_mask_ack =3D irq_gc_mask_disable_reg;
>>          ct->chip.irq_set_wake =3D irq_gc_set_wake;
>> -        ct->chip.irq_suspend =3D ingenic_intc_irq_suspend;
>> -        ct->chip.irq_resume =3D ingenic_intc_irq_resume;
>> +        ct->chip.flags =3D IRQCHIP_MASK_ON_SUSPEND;
>>
>>          irq_setup_generic_chip(gc, IRQ_MSK(32), 0, 0,
>>                         IRQ_NOPROBE | IRQ_LEVEL);
>> diff --git a/include/linux/irqchip/ingenic.h=20
>> b/include/linux/irqchip/ingenic.h
>> deleted file mode 100644
>> index 1465588..0000000
>> --- a/include/linux/irqchip/ingenic.h
>> +++ /dev/null
>> @@ -1,14 +0,0 @@
>> -/* SPDX-License-Identifier: GPL-2.0-or-later */
>> -/*
>> - *  Copyright (C) 2010, Lars-Peter Clausen <lars@metafoo.de>
>> - */
>> -
>> -#ifndef __LINUX_IRQCHIP_INGENIC_H__
>> -#define __LINUX_IRQCHIP_INGENIC_H__
>> -
>> -#include <linux/irq.h>
>> -
>> -extern void ingenic_intc_irq_suspend(struct irq_data *data);
>> -extern void ingenic_intc_irq_resume(struct irq_data *data);
>> -
>> -#endif
>> --=20
>> 2.7.4
>>
>>
>
>