Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3027044ybp; Sun, 6 Oct 2019 03:10:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzaejPqYbOu9dLWJ06L5Ufkn5wDhXEo/inizhP0eqKnebUm4nGUYiERtFYqvJ/twehurxh X-Received: by 2002:a50:9625:: with SMTP id y34mr23495832eda.72.1570356659698; Sun, 06 Oct 2019 03:10:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570356659; cv=none; d=google.com; s=arc-20160816; b=MAfeekaSAvTpXczXVTpmvg53VEhFHDAz39dpXX3jfDL7pmq7nQN4tpaSUGC++m3WIL E5GBk10sc872k1YY6rtm8vg73qZAMJA5bxX92nY6KWlhGJkCwaa4oEstZ2MTwLBC+Pum D//Ebp2Q+/ESU14pIlbjZ1VDYth7ofUMExUbpP26Yzjf3I4PN+xPcasGRNI972G86OSD pzxCkQq11NHAE2iJ8yP/nEe5bJBy27B+W1nN3LKMu3abfaIWbmbtRn+0hEUHFa2rZ610 8q7qgvag4NaDbNFZMk5k6un2Qx89YPEuKl7n69zHwFJ30rXQNV2LeCrc3F/LwwJ0HP0k plsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=h4Pz22UPa4qeikoddOJemZWGELmg//HJHavVVHASgmY=; b=o+xMLCJATcQqkZb5P/OUi3tB425uHNvNcs9nAL+7vQDV9AoS0bGIMiX8DGakrq7HXj fNAnaBSe6asmHYa6I34RI9bX1UDq+KFOzr7vn3QMI2rjwB3AWXFwBqtWLMEaPYYCuaMK 4gfV2GOpFYAV37nH8+LBzubp2lUmdqNpm7d3R8e0KsQe2eKmsHTrOOoobwbNphZpMBb9 TcJMgabomI9FsfsogbFV6YQSqi1jPhZQmdAOt7wVFvWsGDof7IFF5elYoJqYGRCfC6LL lhPvU2xFbp2KWpnZ/hophFDPn7OmCD97kz/shb54NqpxEH2dM94lfLnP4WX2DtycTJjR mQKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id op4si5389634ejb.77.2019.10.06.03.10.35; Sun, 06 Oct 2019 03:10:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbfJFKJ3 (ORCPT + 99 others); Sun, 6 Oct 2019 06:09:29 -0400 Received: from smtprelay0109.hostedemail.com ([216.40.44.109]:52988 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726261AbfJFKJ3 (ORCPT ); Sun, 6 Oct 2019 06:09:29 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 0D0B318224D86; Sun, 6 Oct 2019 10:09:28 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2691:2828:3138:3139:3140:3141:3142:3351:3622:3865:3871:3872:3873:4250:4321:5007:10004:10400:10848:11026:11232:11658:11914:12043:12296:12297:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21451:21627:30012:30054:30070:30090:30091,0,RBL:47.151.152.152:@perches.com:.lbl8.mailshell.net-62.8.0.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: night97_5277490531e42 X-Filterd-Recvd-Size: 1619 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Sun, 6 Oct 2019 10:09:26 +0000 (UTC) Message-ID: <2ed3bf96312dbd9abcd626868ce84e01a066b201.camel@perches.com> Subject: Re: [PATCH] staging: greybus: add blank line after declarations From: Joe Perches To: Greg KH , Gabriela Bittencourt Cc: outreachy-kernel@googlegroups.com, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 06 Oct 2019 03:09:25 -0700 In-Reply-To: <20191006095042.GA2918514@kroah.com> References: <20191005210046.27224-1-gabrielabittencourt00@gmail.com> <20191006095042.GA2918514@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2019-10-06 at 11:50 +0200, Greg KH wrote: > On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote: > > Fix CHECK: add blank line after declarations [] > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h [] > > @@ -24,6 +24,7 @@ struct gb_control { > > char *vendor_string; > > char *product_string; > > }; > > + > > #define to_gb_control(d) container_of(d, struct gb_control, dev) > > No, the original code is "better" here, it's a common pattern despite > what checkpatch.pl tells you, sorry. Statistics please. I believe it's not a common pattern.