Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] blk-wbt: fix performance regression in wbt
 scale_up/scale_down
To:     Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     linux-block@vger.kernel.org, vaibhavrustagi@google.com,
        Josef Bacik <jbacik@fb.com>
References: <20191005185927.91209-1-harshadshirwadkar@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <946f4a47-c4ad-0b2e-4a5b-d0873cbcb510@kernel.dk>
Date:   Sun, 6 Oct 2019 09:25:10 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191005185927.91209-1-harshadshirwadkar@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/5/19 12:59 PM, Harshad Shirwadkar wrote:
> scale_up wakes up waiters after scaling up. But after scaling max, it
> should not wake up more waiters as waiters will not have anything to
> do. This patch fixes this by making scale_up (and also scale_down)
> return when threshold is reached.
> 
> This bug causes increased fdatasync latency when fdatasync and dd
> conv=sync are performed in parallel on 4.19 compared to 4.14. This
> bug was introduced during refactoring of blk-wbt code.

Nice catch, thanks, applied.

-- 
Jens Axboe