Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/3] KVM: x86: always expose VIRT_SSBD to guests
To:     Eduardo Habkost <ehabkost@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Jim Mattson <jmattson@google.com>, konrad.wilk@oracle.com
References: <1566376002-17121-1-git-send-email-pbonzini@redhat.com>
 <1566376002-17121-3-git-send-email-pbonzini@redhat.com>
 <20191001221646.GN4084@habkost.net>
From:   Paolo Bonzini <pbonzini@redhat.com>
Openpgp: preference=signencrypt
Message-ID: <a15e4b77-22ca-e92d-b170-e40b845a5bd1@redhat.com>
Date:   Sun, 6 Oct 2019 18:08:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191001221646.GN4084@habkost.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/10/19 00:16, Eduardo Habkost wrote:
> Wasn't the old code at arch/x86/kvm/cpuid.c:__do_cpuid_func()
> supposed to be deleted?
> 
>                /*
>                 * The preference is to use SPEC CTRL MSR instead of the
>                 * VIRT_SPEC MSR.
>                 */
>                if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) &&
>                    !boot_cpu_has(X86_FEATURE_AMD_SSBD))
>                        entry->ebx |= F(VIRT_SSBD);

Yeah, it's harmless but also useless.

Paolo