Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3380156ybp; Sun, 6 Oct 2019 10:39:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqxO8EZY0mwMv0E05jrFBAaDa9MD7PRzdM3/M6cXOoadFwr3SGG2TZPTtIWVbOaKtWNELDm3 X-Received: by 2002:a17:906:4d0f:: with SMTP id r15mr20303227eju.147.1570383566538; Sun, 06 Oct 2019 10:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570383566; cv=none; d=google.com; s=arc-20160816; b=GH5qzN+B+xq8t4ZKkUmPnAN9+q0UDwleF92BBt1sKdLiokYuDY0fF7B44MZU3EciRh Y9uH3ggPqwDgyEJRKbWnvkLv8klK3QQqyMpS5OWMYIk2CzBTPqzGGM55JvCtNU5ik5Kd g3gBDM6Tg4dsLaufQwIWV9n92Mxd26FkmF7uYgPN84+BiUJaSFBPLajcsgFWt5lUxm46 KO85dnQMG/tb79SGaFnGE7gd/1wA/UytrrHM1dwsaxQDgtstA4dspAV0RqxklEZlruKT gqTaK2kM+Yv7onkVu3XoqSrg2Go7IGWqORzIy2oIlSt6+buqr3z8Os9AIA+a7GAlqMwb yBmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8mPG/rjn9dbW1jrQ0F19PmsqB3ziDWZjkcjRRrj0IWo=; b=nmUXDLaDNOgzYRNQnzh0GAS7+XAT3ZiRI9N9MzYC8c4ZCWLIh/GxgBXB0mHqpgdJOu rcWEjju71nhovszYfS+Hwick0e6trlbOR6xmEnib9qQYy6cNizFzy4iKsQ/d+BA1EyMc 5gGg19j+aIU/kXgPQvpaH4WtekXyP25fYdUxNUvNz4B0iv8H0zLDLDUUusnvTBpTgJKB CT24QH7Uhba3vOe6c0zgOVvgx9q3SrAF67o4yD3FoofBEc1MDvt5xJ4HMmdm61FrAkxt 2kReb81c9iCGI01mrYeZWET9PufQ5xQ2hCyntht8MQWi2zTfRP7Id1DBveF/bJMl7DQC OTrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JPuuX2jb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s41si7613175edm.412.2019.10.06.10.39.02; Sun, 06 Oct 2019 10:39:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JPuuX2jb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729468AbfJFRgS (ORCPT + 99 others); Sun, 6 Oct 2019 13:36:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:35036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727129AbfJFRgQ (ORCPT ); Sun, 6 Oct 2019 13:36:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73C7D20700; Sun, 6 Oct 2019 17:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383376; bh=BlKSi1Xq4EuPHJSs1tQuJ38g3c84qR75o+FZ4x/DhnU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JPuuX2jbU6UsDj0oc1BJzmqn+55T6c0JTFbek0aO67vSIoaO1UM5SL3M1wroW9EUF +EL1T4Cutjl0can1jqRLoXhxe1Y5Px8ic/wymr18aKZung3pV6LRUJvd3bTLNRsnqN oeDOP2+RfVulZBEXE6LW8h70Ldt9QN4Akmkowv0E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eugen Hristev , Alexandre Belloni , Claudiu Beznea , Stephen Boyd , Sasha Levin Subject: [PATCH 5.2 079/137] clk: at91: select parent if main oscillator or bypass is enabled Date: Sun, 6 Oct 2019 19:21:03 +0200 Message-Id: <20191006171215.519681937@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171209.403038733@linuxfoundation.org> References: <20191006171209.403038733@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eugen Hristev [ Upstream commit 69a6bcde7fd3fe6f3268ce26f31d9d9378384c98 ] Selecting the right parent for the main clock is done using only main oscillator enabled bit. In case we have this oscillator bypassed by an external signal (no driving on the XOUT line), we still use external clock, but with BYPASS bit set. So, in this case we must select the same parent as before. Create a macro that will select the right parent considering both bits from the MOR register. Use this macro when looking for the right parent. Signed-off-by: Eugen Hristev Link: https://lkml.kernel.org/r/1568042692-11784-2-git-send-email-eugen.hristev@microchip.com Acked-by: Alexandre Belloni Reviewed-by: Claudiu Beznea Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/at91/clk-main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c index f607ee702c838..311cea0c3ae2b 100644 --- a/drivers/clk/at91/clk-main.c +++ b/drivers/clk/at91/clk-main.c @@ -21,6 +21,10 @@ #define MOR_KEY_MASK (0xff << 16) +#define clk_main_parent_select(s) (((s) & \ + (AT91_PMC_MOSCEN | \ + AT91_PMC_OSCBYPASS)) ? 1 : 0) + struct clk_main_osc { struct clk_hw hw; struct regmap *regmap; @@ -113,7 +117,7 @@ static int clk_main_osc_is_prepared(struct clk_hw *hw) regmap_read(regmap, AT91_PMC_SR, &status); - return (status & AT91_PMC_MOSCS) && (tmp & AT91_PMC_MOSCEN); + return (status & AT91_PMC_MOSCS) && clk_main_parent_select(tmp); } static const struct clk_ops main_osc_ops = { @@ -450,7 +454,7 @@ static u8 clk_sam9x5_main_get_parent(struct clk_hw *hw) regmap_read(clkmain->regmap, AT91_CKGR_MOR, &status); - return status & AT91_PMC_MOSCEN ? 1 : 0; + return clk_main_parent_select(status); } static const struct clk_ops sam9x5_main_ops = { @@ -492,7 +496,7 @@ at91_clk_register_sam9x5_main(struct regmap *regmap, clkmain->hw.init = &init; clkmain->regmap = regmap; regmap_read(clkmain->regmap, AT91_CKGR_MOR, &status); - clkmain->parent = status & AT91_PMC_MOSCEN ? 1 : 0; + clkmain->parent = clk_main_parent_select(status); hw = &clkmain->hw; ret = clk_hw_register(NULL, &clkmain->hw); -- 2.20.1