Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3383512ybp; Sun, 6 Oct 2019 10:43:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqyBjbfHaAMVRhz/3YgHBFADxqbqp9BSkaGwzCt8wniQDB8s5aK6sR4HCnSOwR76VZPqzi5w X-Received: by 2002:a17:906:3286:: with SMTP id 6mr20625561ejw.37.1570383834091; Sun, 06 Oct 2019 10:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570383834; cv=none; d=google.com; s=arc-20160816; b=wUTRbfXrSvfvHZmAW/Of6dYyu3hwnNvaEwra9pQBZZeP4PPfiT9Fq9c5GNCn6TnJxU oSKZ/PnRGnIF3eBwLL//TLw6le4rbVugllc3zC6QoVGWbiCwdXmTZ1trIESy2ZRjr7xN 6ViDFGyLCtAaLFi9PY5xy6C1g9umCxH7JH/NnvZzHjJ5J5GvyCHWqO2t1ufS9OAC9gf/ HZC/nKjVEBK/DWpARaO2QhrmxmeDB9aBcn3hj5Rwr+/sNRhTtd+Xi+OnsOipNfSndryw c9GAJBYefyW+gaTWET7AoyklKmUwBWAPbRkkPQSVYBNl9HNFcZJthhb/FQC4k9hMUglC o5EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8mPG/rjn9dbW1jrQ0F19PmsqB3ziDWZjkcjRRrj0IWo=; b=C2CKzH21B+XhjxeaZqjEy3cKyIeZTCyv0G+s+tQyYq6yIxh5ppzouuEu8f4s0uhTM3 PD1Hw12zYN5Iiihit6Cf/knjSeWdOcDvsh1uQnZRBn3nKW0MaADW/LVaBzMWecc6+kIC K/y3VH+2QJCh71tDRaBLmwp0Mkd/GSHGfhejNKyWToyQVDO6vXLrLUraQtbYt5bVwQZl BJdrrqBKcKD8dh5JaKPqP1f4TO3LuX4JYGWvcPZQL7RHY6TObmFtt4DlOukB9+qv11BK WL6g8ZvTz1cpyMewyi5k9cLf0ZZenS2vfFKqnjskKtl45zfhXWC9w4ENDFLKSWxjt1dX 4qnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k+yFWN41; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b35si7505640edb.204.2019.10.06.10.43.30; Sun, 06 Oct 2019 10:43:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k+yFWN41; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729924AbfJFRmG (ORCPT + 99 others); Sun, 6 Oct 2019 13:42:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:41828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730933AbfJFRmG (ORCPT ); Sun, 6 Oct 2019 13:42:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65EB820700; Sun, 6 Oct 2019 17:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383724; bh=BlKSi1Xq4EuPHJSs1tQuJ38g3c84qR75o+FZ4x/DhnU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k+yFWN41WA+cw0r12jikcCfhSjzclbWleydv5wovs92LAoH7//Im/4KUCKq25CbwV XV2UmfpOU4fTWljSPay4gXI8o3chGgqCkCL7wuOZH2dmLInnLUhncR3K0cYwUBEY5g E/1qJ6hHSHDdEYIqVctAjiiJJDzYuq1/F52ZW2xc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eugen Hristev , Alexandre Belloni , Claudiu Beznea , Stephen Boyd , Sasha Levin Subject: [PATCH 5.3 071/166] clk: at91: select parent if main oscillator or bypass is enabled Date: Sun, 6 Oct 2019 19:20:37 +0200 Message-Id: <20191006171219.379471558@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171212.850660298@linuxfoundation.org> References: <20191006171212.850660298@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eugen Hristev [ Upstream commit 69a6bcde7fd3fe6f3268ce26f31d9d9378384c98 ] Selecting the right parent for the main clock is done using only main oscillator enabled bit. In case we have this oscillator bypassed by an external signal (no driving on the XOUT line), we still use external clock, but with BYPASS bit set. So, in this case we must select the same parent as before. Create a macro that will select the right parent considering both bits from the MOR register. Use this macro when looking for the right parent. Signed-off-by: Eugen Hristev Link: https://lkml.kernel.org/r/1568042692-11784-2-git-send-email-eugen.hristev@microchip.com Acked-by: Alexandre Belloni Reviewed-by: Claudiu Beznea Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/at91/clk-main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c index f607ee702c838..311cea0c3ae2b 100644 --- a/drivers/clk/at91/clk-main.c +++ b/drivers/clk/at91/clk-main.c @@ -21,6 +21,10 @@ #define MOR_KEY_MASK (0xff << 16) +#define clk_main_parent_select(s) (((s) & \ + (AT91_PMC_MOSCEN | \ + AT91_PMC_OSCBYPASS)) ? 1 : 0) + struct clk_main_osc { struct clk_hw hw; struct regmap *regmap; @@ -113,7 +117,7 @@ static int clk_main_osc_is_prepared(struct clk_hw *hw) regmap_read(regmap, AT91_PMC_SR, &status); - return (status & AT91_PMC_MOSCS) && (tmp & AT91_PMC_MOSCEN); + return (status & AT91_PMC_MOSCS) && clk_main_parent_select(tmp); } static const struct clk_ops main_osc_ops = { @@ -450,7 +454,7 @@ static u8 clk_sam9x5_main_get_parent(struct clk_hw *hw) regmap_read(clkmain->regmap, AT91_CKGR_MOR, &status); - return status & AT91_PMC_MOSCEN ? 1 : 0; + return clk_main_parent_select(status); } static const struct clk_ops sam9x5_main_ops = { @@ -492,7 +496,7 @@ at91_clk_register_sam9x5_main(struct regmap *regmap, clkmain->hw.init = &init; clkmain->regmap = regmap; regmap_read(clkmain->regmap, AT91_CKGR_MOR, &status); - clkmain->parent = status & AT91_PMC_MOSCEN ? 1 : 0; + clkmain->parent = clk_main_parent_select(status); hw = &clkmain->hw; ret = clk_hw_register(NULL, &clkmain->hw); -- 2.20.1