Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3388972ybp; Sun, 6 Oct 2019 10:51:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOcCOzBpQdLE/5gEyxokZbxnYw8TkG3eN+awca2HdzslZlW01mwQ/t/GGctTAWO/G+Qvt5 X-Received: by 2002:a17:906:ecf9:: with SMTP id qt25mr19740701ejb.249.1570384282086; Sun, 06 Oct 2019 10:51:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570384282; cv=none; d=google.com; s=arc-20160816; b=sZCjlTxFYFyEjDq5QccGphCpo9eSCgPWh2JMQDNdP3bs3hXS5YaY94uUUJTKY4n9w4 oJfU2sxvNJHugOnjYFnRfsbW4KLUeSqO6hD++rhgc4T/XTWDmkN3F0vsp3F19PKqT0Br svn4nkmlyu97VZbvvu83xqjjXdIA0WAN9rVlNdBJGHGAyhgifHXZ/iAuXVtM0JRFo5un 0WRKPG8mvk6NP71gcQn2SvA5MNB4PGTKF9nmOATjRLF3wsVGxj8TE+aH+iNHsdDzX/g6 g4eL1bttOlflyral3C1d/Vl7T7NnSlNh77tgL9B/oNLBoeB9JT8a2/guzYrANN5Uf3AU uQ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=blMgvXD2udYO/6XOMUBPaGpws48iIsjYyviuixhotvA=; b=dmOK7WdnoXcFQ2iW0oFSkboyHvqsG3dJLN8zmgEtVj0iZIFGrOI9rlokMVr2FNpZNn V9Sn590HYxyoaelPK3HoIEEhfeJBQqfvwS46ZRJ10crVrkX8/7Dk1OAWy7wCCLmYP41T eUPUHAgKYAdfUn7fVJBrndCi40hP31GlapkignoEkfmCeDfXwJXsDU645nI+FK+HRLDo FsGUl7FYISqXQXvGXExgYluemCQ0+wSGHe+mDrLrN/SHQKZdMRuk/OmATTTrz/PutC+T oUr0//KjbL3qrbI+2OQGwqKv5cBqIGDLYgwQG/33itGlEzBsr5cNg1Vu95xqMZTmwwjQ 4giw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SSYDMiOR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si5918256eja.146.2019.10.06.10.50.58; Sun, 06 Oct 2019 10:51:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SSYDMiOR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731274AbfJFRlu (ORCPT + 99 others); Sun, 6 Oct 2019 13:41:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:41440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730609AbfJFRlr (ORCPT ); Sun, 6 Oct 2019 13:41:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A6A5220700; Sun, 6 Oct 2019 17:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383706; bh=ufQvx7ZNex7e9L1n3iz0qxl2DPV4jX3rgvJ6+P7qKWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SSYDMiOR3t3SufEsLMb6ZjPfbrZFdtHrAuB2UN681CPgFBML/Q5jSFcO6H7FPhi7F kULyAcic1T5hBZDj2saGveojzN+w5Fj0vMU5ElLOGCciWfww64Olf37zMVyGb0oLZ9 aTsd8f61H+YMLuYHx0ETFUhmvr+zDm1+FWk27iJw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Douglas Anderson , Taniya Das , Stephen Boyd , Stephen Boyd , Sasha Levin Subject: [PATCH 5.3 065/166] clk: qcom: gcc-sdm845: Use floor ops for sdcc clks Date: Sun, 6 Oct 2019 19:20:31 +0200 Message-Id: <20191006171218.762161698@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171212.850660298@linuxfoundation.org> References: <20191006171212.850660298@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Boyd [ Upstream commit 5e4b7e82d497580bc430576c4c9bce157dd72512 ] Some MMC cards fail to enumerate properly when inserted into an MMC slot on sdm845 devices. This is because the clk ops for qcom clks round the frequency up to the nearest rate instead of down to the nearest rate. For example, the MMC driver requests a frequency of 52MHz from clk_set_rate() but the qcom implementation for these clks rounds 52MHz up to the next supported frequency of 100MHz. The MMC driver could be modified to request clk rate ranges but for now we can fix this in the clk driver by changing the rounding policy for this clk to be round down instead of round up. Fixes: 06391eddb60a ("clk: qcom: Add Global Clock controller (GCC) driver for SDM845") Reported-by: Douglas Anderson Cc: Taniya Das Signed-off-by: Stephen Boyd Link: https://lkml.kernel.org/r/20190830195142.103564-1-swboyd@chromium.org Reviewed-by: Douglas Anderson Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/qcom/gcc-sdm845.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c index 7131dcf9b0603..95be125c3bddf 100644 --- a/drivers/clk/qcom/gcc-sdm845.c +++ b/drivers/clk/qcom/gcc-sdm845.c @@ -685,7 +685,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_names = gcc_parent_names_10, .num_parents = 5, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, }; @@ -709,7 +709,7 @@ static struct clk_rcg2 gcc_sdcc4_apps_clk_src = { .name = "gcc_sdcc4_apps_clk_src", .parent_names = gcc_parent_names_0, .num_parents = 4, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, }; -- 2.20.1