Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3393311ybp; Sun, 6 Oct 2019 10:57:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqytvFQwwTFcwOhM7YQXFBw4d0neqfNJMbWZ8RY7hWIyT9QT6Aciju9Am0WE9PCvR5Mah/wL X-Received: by 2002:a50:9e65:: with SMTP id z92mr25687884ede.49.1570384669428; Sun, 06 Oct 2019 10:57:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570384669; cv=none; d=google.com; s=arc-20160816; b=rTg6s7wvFdr44EN0BkhM+31oxw0+g+Hz/Pok0l/gRX2fiII9EADZwAhhMpwilLF8zw +TG2uPwh8dj/vo2OZ//8ko7nMBSVy6soqA55Bc30v2nOi8FjpuO6ZJ3Z9Zra/Av2b2pf 9idPZU7grSgqnQrqBc+Wpq+e9Bopqjn4/X6eaYf93pGR++QriQGsO1Ir5hl4fTZaD6WO Z4j5IgiXCQ9VbFte6mDzGBcnJEAtwePGqGqt5PLAntd1GhG6Sr5sQYMQDtqjClDNsHOg q+Vx+WPSO2nAVR+1H/LlpKI1kix2Or8+Xh2joHVvuE1aWLft4goqpP10aZNK7PMkilfH IV2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HyQFFoPIO0OkGQ86cLYmy4OVqBDoozjJKLI4bxr27Gg=; b=IyqBF/AY4tbCQd6wyKKvmJ3hinimnnsLxHEV8KOs4bH+UZR8FOUIqwa7PR4aFtWcx2 dGuBVEUpfMuEXIURonjCQQ2OdX1hpdMZGFMUDpTI0ZtoJuId+TgHUkFuJNLy1SmpxIw0 fuwQGHrxikRn6GyE8HDC4PmueLzdMu/kboklKJjUbrGrV72KQPipwJAOjnOxvTKvt4e3 HLqOa62zhf8mrhpDUI8DXSNp2zkzuKsm2mgcpkjxetitm3YcBmwKZc0yoHZQW+APgzme ZCtg0Ev77kql/C7fM8uSADAH88BJKjw88s7Gu0adLTVrLYtFVNOzXImoHDQmgkWIBKua 5M7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ix+wpdIW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l19si6820989eds.389.2019.10.06.10.57.25; Sun, 06 Oct 2019 10:57:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ix+wpdIW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730091AbfJFRgL (ORCPT + 99 others); Sun, 6 Oct 2019 13:36:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:34864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730058AbfJFRgJ (ORCPT ); Sun, 6 Oct 2019 13:36:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68B7F2064A; Sun, 6 Oct 2019 17:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383367; bh=PWhTwKba2ZSNQzRTJqTmC99Bkw2ToZ0yxWIRCb0nwZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ix+wpdIWo0RfrmBGhWD89QvTyZbaS3OwFCr1TrA7y7WAwtYA6KO7rzhhMIzKuIyFb JicUTZLMEoPGAtks2YFZ7xon0oXQiMAafzhzS4DECIRhSSedgaRRhp97RR1uDegNEJ USnKAXNl94gm1rHHBbhLxREyxLBvqWhNIkp9kE08= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Otto Meier , Linus Walleij , Sasha Levin Subject: [PATCH 5.2 076/137] pinctrl: meson-gxbb: Fix wrong pinning definition for uart_c Date: Sun, 6 Oct 2019 19:21:00 +0200 Message-Id: <20191006171215.348423201@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171209.403038733@linuxfoundation.org> References: <20191006171209.403038733@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Otto Meier [ Upstream commit cb0438e4436085d89706b5ccfce4d5da531253de ] Hi i tried to use the uart_C of the the odroid-c2. I enabled it in the dts file. During boot it crashed when the the sdcard slot is addressed. After long search in the net i found this: https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856 After changing the pin definitions accordingly erverything works. Uart_c is functioning and sdcard ist working. Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins") Signed-off-by: Otto Meier Link: https://lore.kernel.org/r/1cc32a18-464d-5531-7a1c-084390e2ecb1@gmx.net Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index 6c640837073ef..5bfa56f3847ef 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -192,8 +192,8 @@ static const unsigned int uart_rts_b_pins[] = { GPIODV_27 }; static const unsigned int uart_tx_c_pins[] = { GPIOY_13 }; static const unsigned int uart_rx_c_pins[] = { GPIOY_14 }; -static const unsigned int uart_cts_c_pins[] = { GPIOX_11 }; -static const unsigned int uart_rts_c_pins[] = { GPIOX_12 }; +static const unsigned int uart_cts_c_pins[] = { GPIOY_11 }; +static const unsigned int uart_rts_c_pins[] = { GPIOY_12 }; static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 }; static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 }; @@ -439,10 +439,10 @@ static struct meson_pmx_group meson_gxbb_periphs_groups[] = { GROUP(pwm_f_x, 3, 18), /* Bank Y */ - GROUP(uart_cts_c, 1, 19), - GROUP(uart_rts_c, 1, 18), - GROUP(uart_tx_c, 1, 17), - GROUP(uart_rx_c, 1, 16), + GROUP(uart_cts_c, 1, 17), + GROUP(uart_rts_c, 1, 16), + GROUP(uart_tx_c, 1, 19), + GROUP(uart_rx_c, 1, 18), GROUP(pwm_a_y, 1, 21), GROUP(pwm_f_y, 1, 20), GROUP(i2s_out_ch23_y, 1, 5), -- 2.20.1