Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3397779ybp; Sun, 6 Oct 2019 11:03:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqyF6zAdQ/SHJEHM7lc0xXOXnBs2d/PhQR80iWEhOfdsHPBHn0xRMxHascm23Q97+ioeA8Sk X-Received: by 2002:a17:906:fc2:: with SMTP id c2mr20596460ejk.261.1570384985400; Sun, 06 Oct 2019 11:03:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570384985; cv=none; d=google.com; s=arc-20160816; b=kAh+0SDv64iRbR9Au2ivPQ9zL3zmXnvUWXagDYzv23ZQD1TuwnFa2mVwMQFVMe0O0q 8ely347IiHCFI6/0v2+uFT0pN8umza7JBPoeJn74siT82RWxQMVOrO8jKHb6/sb5lfXi QdvRqae2LdmJod7xz3o2B1dUiAxeN6Rl09p7OlE6Ivutg3igJ/F0RbDeFKvKUFzP3eki WjqZl0E109qxF/rDfccBsXejvGpp20INWp7aQREVuyFCHrb69UIUE8JZlb8CNoyFINV9 TZqcQ93rJrJWaTN+KUXCmSCqdAf5Gl3B3+1AbRtapK/tCxk9NhaohHfpdGSYICUe0fyL t9SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=I/brzNIF5R9+oVAH/1+nKpFmAHdqGXFTbCmnj0z1ge4=; b=pDkWby9ZAb4uSQgn1tIyK8fzU0aD46i7fyLO44TljNt6mE8s3Scg8g71pBYBp61Kh1 HI43wvQrfOdO57YxCnUTZv/QactkQmdyFm6skr/Ea3F6YjtvsvlsvFs+oQ6kp4br+Xy+ ufZWBX28moHQx1EONCbme5gR0shfwxweRYQrWPYtUKyjmKsmm+5oo1xRPdHl1ok2IOCa xxMI9lTxmvJduyZaO1pVqtEME7b2AFTjEUjONyZBWi2ZtUdsysM5q1riWy3oZzWt1FX/ iVh15v76RImonMQ+bM/boeX5asTZAXG8xz6nxfRAqb9TTZ4YH9bYaExfOSGFWIj8/+WI nnGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yCak8zlG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s21si6446913ejm.122.2019.10.06.11.02.41; Sun, 06 Oct 2019 11:03:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yCak8zlG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbfJFR03 (ORCPT + 99 others); Sun, 6 Oct 2019 13:26:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:51604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfJFR01 (ORCPT ); Sun, 6 Oct 2019 13:26:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 263CA2077B; Sun, 6 Oct 2019 17:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382786; bh=NpFt4VysNHZNSD9PF2n48smfBRcHUrmddrU3O6zZY+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yCak8zlGBbn2AaD9r7tcisQvp7J7fEevldpZkl4Z/6wxufe4ODvrs5aNJZttWKW6g NJVfZwlL9d4ifwPBRCzs12fxNkx5IIP1soNVlqwWIWOuSAyXxZnTVyui81qnXJCZHu 0R0R3UIbNmXjkYMdEo/sVfmnOumbks5f74t8m/mg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marko Kohtala , Mark Rutland , Rob Herring , Daniel Vetter , David Airlie , =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= , Bartlomiej Zolnierkiewicz , Sasha Levin Subject: [PATCH 4.14 06/68] video: ssd1307fb: Start page range at page_offset Date: Sun, 6 Oct 2019 19:20:42 +0200 Message-Id: <20191006171111.188642446@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171108.150129403@linuxfoundation.org> References: <20191006171108.150129403@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marko Kohtala [ Upstream commit dd9782834dd9dde3624ff1acea8859f3d3e792d4 ] The page_offset was only applied to the end of the page range. This caused the display updates to cause a scrolling effect on the display because the amount of data written to the display did not match the range display expected. Fixes: 301bc0675b67 ("video: ssd1307fb: Make use of horizontal addressing mode") Signed-off-by: Marko Kohtala Cc: Mark Rutland Cc: Rob Herring Cc: Daniel Vetter Cc: David Airlie Cc: Michal Vokáč Signed-off-by: Bartlomiej Zolnierkiewicz Link: https://patchwork.freedesktop.org/patch/msgid/20190618074111.9309-4-marko.kohtala@okoko.fi Signed-off-by: Sasha Levin --- drivers/video/fbdev/ssd1307fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index f599520374ddf..5f7dbf1c46092 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -433,7 +433,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) if (ret < 0) return ret; - ret = ssd1307fb_write_cmd(par->client, 0x0); + ret = ssd1307fb_write_cmd(par->client, par->page_offset); if (ret < 0) return ret; -- 2.20.1