Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3398371ybp; Sun, 6 Oct 2019 11:03:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzaDtuGzS/4WW+TjG2neKqluSROln3GaZKlJKlOA1geKCp66DUmoySS3Hhz0IJBymGLKNMd X-Received: by 2002:a50:ce06:: with SMTP id y6mr24918514edi.282.1570385018754; Sun, 06 Oct 2019 11:03:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570385018; cv=none; d=google.com; s=arc-20160816; b=vwLlln56Q0TeVdou+I2ydKO7kNeK6EeCYIVci1lexrE7IsdBfqb+cwoe9I3wxN11Mx dS8eRR4HbHhcvW/+HWQKGU9RIiqTv8YxN1tMCDN8mXJ1Bw7BiaTE+gFGsATYmP8pYSff AmF8q5FfrlwgTWEX2sQeFhzcITjSALj8y/PX8FyPyAEIJUq7UIHMFtrFHG5tLRNirnYE EKla0UUWVLUMexkd1c1TM1+Yd+bBHdKiA/bqROh7i+EGGj6q3DJZVdCi4fUqtpcxsski PrMqZaD38vd6di2NpCQ3ISNqkWi40q1/G8DOhgsl5Cfx7A/4H4buF14mOr4qSpkquzWq Tv0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=czpoGelaZasakUHKvgSNYIQb5UabuqXRypJMxthQUcs=; b=kpBSybT3f8zdj3pRWjaCf3wMf9WHuSJSgTPkiW/SdzEB+dZxP4afQd94oIlLjFls5f UWqIsNvjZ7lOu9NoLnq+w76FF9bxrnzPXZDAdyMFP2TFEZfGonQLYTFCLHHpTODAO3y0 1f1lkvC5O45Erap+YQcoiVDKWGrBWjOSLAZ9kZt14ZUZsJwYsFDXTDPKtMFuQeJ9o0rq ZUC1YdDhCcDV118sQ8PIHWlpCe2jYX1pyhoONBNyvyNMXWpAJyfktH8Z10LTYGXnWukP FZWZO7EyuSYWJd7Vz3ZenHKntvJoHRnwWSaVFKPF68KG4TEVgaaGHp5BAFC5UuLGCrA4 YOkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ffv4BVgo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f19si7745863edb.385.2019.10.06.11.03.14; Sun, 06 Oct 2019 11:03:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ffv4BVgo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728167AbfJFR0B (ORCPT + 99 others); Sun, 6 Oct 2019 13:26:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:50870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728129AbfJFRZw (ORCPT ); Sun, 6 Oct 2019 13:25:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1941120867; Sun, 6 Oct 2019 17:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382751; bh=on4MoXKLcBAAwcvGInINaSXEOabjhNW79FFPggjuvbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ffv4BVgoqTyhmEWH+v9eMSLGIHSuespRUeAT9h72I3mr+dEMW3/k+yktRZ01tbxPf AH1tGRNbCQQrh+PT8p8v1C3+ZeNLkcjWMoarpu4yITyE0blp6vUeEGGREOxifxTUiv 3ynNC9uJ7MfSfssECepI/ZHaA/oT7XcHf9y5iWdc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eugen Hristev , Alexandre Belloni , Claudiu Beznea , Stephen Boyd , Sasha Levin Subject: [PATCH 4.14 26/68] clk: at91: select parent if main oscillator or bypass is enabled Date: Sun, 6 Oct 2019 19:21:02 +0200 Message-Id: <20191006171119.982471947@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171108.150129403@linuxfoundation.org> References: <20191006171108.150129403@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eugen Hristev [ Upstream commit 69a6bcde7fd3fe6f3268ce26f31d9d9378384c98 ] Selecting the right parent for the main clock is done using only main oscillator enabled bit. In case we have this oscillator bypassed by an external signal (no driving on the XOUT line), we still use external clock, but with BYPASS bit set. So, in this case we must select the same parent as before. Create a macro that will select the right parent considering both bits from the MOR register. Use this macro when looking for the right parent. Signed-off-by: Eugen Hristev Link: https://lkml.kernel.org/r/1568042692-11784-2-git-send-email-eugen.hristev@microchip.com Acked-by: Alexandre Belloni Reviewed-by: Claudiu Beznea Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/at91/clk-main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c index c813c27f2e58c..2f97a843d6d6b 100644 --- a/drivers/clk/at91/clk-main.c +++ b/drivers/clk/at91/clk-main.c @@ -27,6 +27,10 @@ #define MOR_KEY_MASK (0xff << 16) +#define clk_main_parent_select(s) (((s) & \ + (AT91_PMC_MOSCEN | \ + AT91_PMC_OSCBYPASS)) ? 1 : 0) + struct clk_main_osc { struct clk_hw hw; struct regmap *regmap; @@ -119,7 +123,7 @@ static int clk_main_osc_is_prepared(struct clk_hw *hw) regmap_read(regmap, AT91_PMC_SR, &status); - return (status & AT91_PMC_MOSCS) && (tmp & AT91_PMC_MOSCEN); + return (status & AT91_PMC_MOSCS) && clk_main_parent_select(tmp); } static const struct clk_ops main_osc_ops = { @@ -530,7 +534,7 @@ static u8 clk_sam9x5_main_get_parent(struct clk_hw *hw) regmap_read(clkmain->regmap, AT91_CKGR_MOR, &status); - return status & AT91_PMC_MOSCEN ? 1 : 0; + return clk_main_parent_select(status); } static const struct clk_ops sam9x5_main_ops = { @@ -572,7 +576,7 @@ at91_clk_register_sam9x5_main(struct regmap *regmap, clkmain->hw.init = &init; clkmain->regmap = regmap; regmap_read(clkmain->regmap, AT91_CKGR_MOR, &status); - clkmain->parent = status & AT91_PMC_MOSCEN ? 1 : 0; + clkmain->parent = clk_main_parent_select(status); hw = &clkmain->hw; ret = clk_hw_register(NULL, &clkmain->hw); -- 2.20.1