Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3652933ybp; Sun, 6 Oct 2019 17:05:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHlpeDj3mhkGw1FgzO4LmI/0w5OqvuOGSoDC6rhlcklQ1QfbW4Qx7RolJO1TQV9NtTozOl X-Received: by 2002:a05:6402:b13:: with SMTP id bm19mr3567687edb.152.1570406706475; Sun, 06 Oct 2019 17:05:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570406706; cv=none; d=google.com; s=arc-20160816; b=SxM4sVmWC1AwQMFmPWYwfEOIPZfG1ZQ7CulaJCBccmzEHV41MySSA5/k5RonqDCLxE yCLj/GUegriu2zea1M7rrB2LB8QRWymBtc/IIlF/DHKrkQF4C/fzigYMijBMifp/+5XX RoMtLYShnRgg2/1YsqQayJ0uBkvXUyEHTKLaklOE7idfd0ueScOJJOeHeCiolEWMvJZ+ oFz9bjeqnAGpL6DDPtgxx1GnbKslbw2um604FDsjHVb5YJEcRVYvYuh7hTehfqeFHmzd 6FqNpprgx9MujAEfJP6WLOJveqXQud9117NokCn9BTEfSxD8+1gVXNsdM99GkZa14/fw o9Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=0OGHKPj+Wv5bJqZl+51TCg/isw7AhFW5RqOkp5nI8pY=; b=Xd52Jovg6z1rwtAOq9iG65tosb3OE/L3PLOsRb3N3eHiw3zY7l7vKP+0ouGrOMIWmD 6HG1YLzgDbhvstaQXBSesqVLd0ssu+x5Ybmx+g4ig2Owp+OhIdX4hoJvaQvLdyVqRPfl OUgYG5s4j6frajrh/v85Obhy3i7k5l1GtGbGJFmRHIx9bUsja6N2VMwkGYoADP72ucmN WX9xNyvOOPm180xcN0RBUn2rWvGx0RhG2ejoiODZUrs2HhNRswUldjxI0UIsE3NKEzC+ /z1j6nW5s0FvT3AkeRTK2/u2l3HwgsCYOpULmLXblvzN6JcS1v/dhxS8WrB0BZ3xAmVs PsFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=RbxYapSC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e10si6169993ejr.222.2019.10.06.17.04.42; Sun, 06 Oct 2019 17:05:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=RbxYapSC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbfJGAEO (ORCPT + 99 others); Sun, 6 Oct 2019 20:04:14 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46157 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfJGAEO (ORCPT ); Sun, 6 Oct 2019 20:04:14 -0400 Received: by mail-pg1-f195.google.com with SMTP id b8so748310pgm.13; Sun, 06 Oct 2019 17:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0OGHKPj+Wv5bJqZl+51TCg/isw7AhFW5RqOkp5nI8pY=; b=RbxYapSCPmtOvzif62cXaYKpWjbEj/Acwk/Pec1HgdvlFcj6qTE/b1FaaocjPpdZbI 5RHuFu6c24q0fQG3/lVTrwMJopULCDK5xWD0SRCIVhjsAiYgkAj5bcYjrjQs9zgJ48JC NwHL4RG+EB9QWu4yH9rhlL6NCCJ4G8qt5i/2vr7nGzOCfP59oJSgktxzsXF7jVebT4q0 nAzQ4OwKKZf2isV+MJtaE+55w4xv/Q4nH8+Tw1Eqrw57EMTGrxdmYDSakv2aBitfKu/m YXu1KSurW+vJx3mRDEuHKaLMOCh/2kJjFXXn23P5OehPGGTFNn2R74eoVEKHXw7e7vuC BiDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0OGHKPj+Wv5bJqZl+51TCg/isw7AhFW5RqOkp5nI8pY=; b=lmeXznYnS093z+IJ6GcrA+Mn+jxnVsFy6i/bou0k88H0XaBYfrViVd34Zm1g20MgKo Gin121ykW7kXv9tZ/vzPk4rHZh0Trri8+cEMRqPObaSyAIqpa5OTRmKEwji78GkoHgpX vTATvw2ylHjpE9n9O4uNtwQBdLpqcW/fgPpdi7hYJG4w1T0vMOOduz47sKZGm0mDyUAG 41owrh12S5lZfcJDpyFLv26z3yq4O4xES/SksVxNQUvJSti9WGguvLiysskPaqoyqubq 69WqQfU0BUHsqz6A4iFNXQ2ZbhF6lLIYxa3KBgqBfRdPHfcyTZPC+y7MRvhGKSMagPMH GSOA== X-Gm-Message-State: APjAAAV0U1rbVumfERnr3mEHt95PJs9FW2DkmevMqgviZbxHXHqR63q1 98MCmDFz3X09BFmgQ7kZx7x/vhP2 X-Received: by 2002:aa7:928b:: with SMTP id j11mr30350725pfa.237.1570406652891; Sun, 06 Oct 2019 17:04:12 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y36sm2055693pgk.66.2019.10.06.17.04.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Oct 2019 17:04:11 -0700 (PDT) Subject: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user() To: Linus Torvalds Cc: Linux Kernel Mailing List , Alexander Viro , linux-fsdevel References: <20191006222046.GA18027@roeck-us.net> From: Guenter Roeck Message-ID: <5f06c138-d59a-d811-c886-9e73ce51924c@roeck-us.net> Date: Sun, 6 Oct 2019 17:04:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/19 4:35 PM, Linus Torvalds wrote: [ ... ] > Anyway, let me think about this, but just for testing, does the > attached patch make any difference? It's not the right thing in > general (and most definitely not on x86), but for testing whether this > is about unaligned accesses it might work. > All my alpha, sparc64, and xtensa tests pass with the attached patch applied on top of v5.4-rc2. I didn't test any others. I'll (try to) send you some disassembly next. Guenter