Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 6 Oct 2019 22:48:01 -0700
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Brian Masney <masneyb@onstation.org>
Cc:     robdclark@gmail.com, sean@poorly.run, a.hajda@samsung.com,
        Laurent.pinchart@ideasonboard.com, airlied@linux.ie,
        daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        freedreno@lists.freedesktop.org, jonathan@marek.ca,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH RFC v2 3/5] ARM: dts: qcom: pm8941: add 5vs2 regulator
 node
Message-ID: <20191007054801.GH6390@tuxbook-pro>
References: <20191007014509.25180-1-masneyb@onstation.org>
 <20191007014509.25180-4-masneyb@onstation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191007014509.25180-4-masneyb@onstation.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun 06 Oct 18:45 PDT 2019, Brian Masney wrote:

> pm8941 is missing the 5vs2 regulator node so let's add it since its
> needed to get the external display working. This regulator was already
> configured in the interrupts property on the parent node.
> 
> Note that this regulator is referred to as mvs2 in the downstream MSM
> kernel sources.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Picked this patch for now, once the driver updates are landed I will
take the last two dts patches.

Regards,
Bjorn

> ---
> Changes since v1:
> - None
> 
>  arch/arm/boot/dts/qcom-pm8941.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index f198480c8ef4..c1f2012d1c8b 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -178,6 +178,16 @@
>  				qcom,vs-soft-start-strength = <0>;
>  				regulator-initial-mode = <1>;
>  			};
> +
> +			pm8941_5vs2: 5vs2 {
> +				regulator-enable-ramp-delay = <1000>;
> +				regulator-pull-down;
> +				regulator-over-current-protection;
> +				qcom,ocp-max-retries = <10>;
> +				qcom,ocp-retry-delay = <30>;
> +				qcom,vs-soft-start-strength = <0>;
> +				regulator-initial-mode = <1>;
> +			};
>  		};
>  	};
>  };
> -- 
> 2.21.0
>