Subject: Re: [PATCH] PXA2xx: build PCMCIA as a module
From: Richard Purdie <rpurdie@rpsys.net>
To: Florin Malita <fmalita@gmail.com>
Cc: rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org
In-Reply-To: <1136409389.14442.20.camel@scox.glenatl.glenayre.com>
References: <1136409389.14442.20.camel@scox.glenatl.glenayre.com>
Content-Type: text/plain
Date: Wed, 04 Jan 2006 22:20:20 +0000
Message-Id: <1136413220.9902.94.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1048
Lines: 27

On Wed, 2006-01-04 at 16:16 -0500, Florin Malita wrote: 
> This patch adds support for building the PCMCIA driver for pxa2xx Sharp
> platforms as a module:
> 
> 1) platform_scoop_config is currently declared in pxa2xx_sharpsl.c but
> referenced in the platform code - move the declaration in the platform
> code so pxa2xx_sharpsl.c can be built as a module.
> 2) export soc_common_drv_pcmcia_remove which is referenced in
> pxa2xx_base.c.
> 
> Please apply.
> 
> Signed-off-by: Florin Malita <fmalita@gmail.com>

NAK. This breaks poodle, tosa and collie who also use scoop and this
pcmcia driver. I'd suggest moving scoop_pcmcia_config to
arch/arm/common/scoop.c instead. Whilst this means scoop can't be a
module, the hardware isn't going to do much without it so I have no
objection to that.

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/