Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3976256ybp; Mon, 7 Oct 2019 00:48:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqywwwUiuRjYwH96OdfyuIkjFck1Zz8I6JP2J+xyxgeYXj3S/X5GPBrI0fxh96+XPQ44DFiT X-Received: by 2002:a17:906:c7c6:: with SMTP id dc6mr22942240ejb.123.1570434521593; Mon, 07 Oct 2019 00:48:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570434521; cv=none; d=google.com; s=arc-20160816; b=CCAbfNo7/7GPG1RA9Bn6N8J7C5Eln3jCkHumWL2f9sjVjbo2Qhr6a3+tyPE3K1GGkV /D+Qr4rMZAeddt4edsMlVrMoml8Gc5tzAUPeMiq3uEsFK1I+HbKUpuM+Z8zkzGA/W2yF Csd6IE56QkXr/ftc72pxWWOEwXkfNPKX7f1ZUXL3hCwebDEq4ev52UxUrOE77+cuI7E3 pwQmIu8n/xX5SEx6QYqsRiHLBtdi5QmjzDowEEzyf5QE3h5TfAg+T9tRarWuznkSaadw wL+8/miEnChuxeMrhFEye62hVBBS47BdOT+joSXj9TKcc4sukbsvM60XuuG31tSuFKWG GS3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:from:references:cc:to:subject :dkim-signature; bh=2dSyWOWDhs1Oyl8TZBuUtDp4oJHExe1QxDI3Ydw7q0w=; b=FkjodJJTi8cvNkg4jnjTxnTfm7wxBdW1D99XPgBoss+HLNszQRKktQMPZr252bDrlP 4CVdsyyOVevs0nENSvuD7mrq+hLMYtF1jvT7+vFefjsjqz90+sVBzOSBD4etdrPH7SSp omJXxFXJIzRwXlUY9XkgPkmFeM4+/SF8h+I8Dj4IHnB93cfCmihnXSJaYxrzAivkeWkk OmHXJUCGta6jbCH8kKHneHCeIGelYzUuTAhNrJUCkdCNt2vFsbZ0Ne0Gz1k65l0CzQJ6 KfYN1KbfGS1YOj4U1rCPgWZfACn1RGYUEIz8EaDlQ5+KpmwMsHFdXPLa537Hk7dxsEZc LnlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=cKeNR7wl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y27si8652499edd.249.2019.10.07.00.48.17; Mon, 07 Oct 2019 00:48:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=cKeNR7wl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727395AbfJGHo7 (ORCPT + 99 others); Mon, 7 Oct 2019 03:44:59 -0400 Received: from mout.web.de ([212.227.15.14]:59439 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbfJGHo6 (ORCPT ); Mon, 7 Oct 2019 03:44:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1570434273; bh=2dSyWOWDhs1Oyl8TZBuUtDp4oJHExe1QxDI3Ydw7q0w=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=cKeNR7wlq0sX/ZyvPoodQLRbTe6Ckgh5v9ZTe5qIPYC5i356rUG1jgt6Hes/R8dGo MPdaRCdpmuDkBSkiPYhFcKzSyWa6kegKjsnEKRzGAAAkfbRQavt3TxH90nkvXghHRV afjZpUXIZ2zdAfiY/1F27x0a4w9bBPeaRTKoBrGo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.131.146.95]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Mf0qf-1iSb1c2php-00ObRG; Mon, 07 Oct 2019 09:44:33 +0200 Subject: Re: drm/imx: Checking a kmemdup() call in imx_pd_bind() To: Navid Emamdoost , Kangjie Lu , Stephen McCamant Cc: Navid Emamdoost , dri-devel@lists.freedesktop.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, Daniel Vetter , David Airlie , Fabio Estevam , Philipp Zabel , Sascha Hauer , Shawn Guo , LKML , kernel-janitors@vger.kernel.org References: <20191004190938.15353-1-navid.emamdoost@gmail.com> <540321eb-7699-1d51-59d5-dde5ffcb8fc4@web.de> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <1b86ce88-ec28-0710-b624-e1eded248da2@web.de> Date: Mon, 7 Oct 2019 09:44:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Provags-ID: V03:K1:/b5pm8brQdCRG2IP/nlNNxu5f7gmuqwSyWK18sL+S50SmvWN3E8 eGDTILF3Agu2zseK1HJaQHEJ4KSTYmHK7LtAcwYT8eMi4oKVW66CiB850eM3BnZhxJW82bM cR4NePe6MXMtCsCl5X86jJOY6uUHwFU29X9nOeJ8i67P/6o7h5XgZmty5WdLfIrYIEIu0QU AL/KDiNTwZ5CTfFlv9aJQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FTj6oU+ZtOY=:8RFGc7WseGgVIaMeUNoBO1 MHz8z7tN1Pjgb95obL1IOhYomg5lr7XLbiFbJju643XwmUquXa/NAAxklUCY9CNvaDnQUh3oN +w1zZLixcxC3o1+UmbLKOxvUS6cqvUdlRk5DSJSNEysXguA4QHXhoGHicGucHznXcqw7nrLAn Vr1hCyrnY1kAwh5uRZqjeihlzG8PXRD3ejwQdwbjfYuN3kCfiBqnQLJ4vk+tn+l6v5FOwQ5Cp bmFpysfUz396BNK8Uoc7LXu5fw4VAB2rjqy9Wxea4E6vsm307G8EG4W1KN5XWBhxQ+g1dpXXJ 9DISUhSFn4l5qba55OpGE96H7ai29C8rXY6TvSYmJ/VqI5iprrJvRu09vC5M7gRzgD6ka+Bgu Pt5R0Ixz6wIpV4m+RxFiwO5fEtsNKZ9jvcwEOxWCodE9JZjfE37mZVPqkc5cBxGdAoZB96W2I t+t0WVhkuo059ANzIM6nwvy9Aa8QNXIUrT0y05GVyuOzij527i44ls2OwwexLVbXxOWxymSfU pbRQhR2pPhLOCW+ZOy4714H+Ag/TV+IlrxwjU7YjH85iB2O7k4QL6PVHccO3+4DWo/It+FTjv /NmO4zl4wBiRS89JlMsRXKMFjLMSP03igrrpdqKPsAIBl40l51mm7Bcpwzk3oS9kPzh+OnR+b KlBxW8+UkLbmryUWZ3/Fa9cDYXrw2JKImVVExxhNgNWGvOHa+Fg7ujrMLgr42KfkzMVUpO1wG 0BrfVQKJX7THwdwKXcA51XeUQfzUgNxWP7zleMk3oVHJFIEvaZLuTUZZVU/86J6UwF+upuBQN zIMXaGN6dhjDhTtd7Rn+0WC9s9OdxF8W4FzzZxJUmdOjmxNHd4uYhTaK06ffI6BnD7Rij2isz tHjJSxtqCr9RzQpI+tU4qIthT6NKV2umqAcdBAGFhoYX/P1iDVBDyDOgtynRqigc2KkUJLyuc V5Ri9oEU/DRvYOxmpycHeuasRZ0hGaJewtHS941o31R3PnIlrs3UGAZBhUgIbYzwgi3MNOhuJ VmlZRVrlHuo55vDof5hxhJRwnZGeeD/ehYbV74PCS7fl+QnyWYVspR2ACNQSx3O8BKuKXtZJ7 BlFAgZP5fRelS0rrTiLgeSAAe03sqqdy/YpIGP2EHrrmTf1Ih5IHV0m3e4i8HlB4p9gp6ZPFZ GDjY3IbJcJ4Wh3af0pjCfXTSco6sqTOA9oglvUO1rgucfVQ4LrGWwl/yqCK9LDXIjzjiFEyIe l4nK3e1SeWyY96jv41pBQXe45icGAeoa+CokMaExmH5S+jDsZyJDKLcTxKd0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I agree with you, kmemdup may fail so a null check seems necessary there. Would this place (and similar ones) be pointed out for further considerations also by the source code analysis tool which your software research group seems to be developing? https://github.com/umnsec/cheq/ Regards, Markus