Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3984748ybp; Mon, 7 Oct 2019 01:00:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJ/Erj0QE1JLtHP1nIOZFV1BOTlnPqESMPOhQTKbzlFG++p4bADnQZ+egOfTHGl6PtUaaX X-Received: by 2002:a50:a7e4:: with SMTP id i91mr28607723edc.9.1570435239897; Mon, 07 Oct 2019 01:00:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570435239; cv=none; d=google.com; s=arc-20160816; b=QJAwFCgf/5xSHx5+eTUMv8eC+Qq4cGOo4J3viFOOKqwkPChX8yOLla7L2lOpL5Z9Vq Qh+I5ow3PtTr81//hXG5624fVQXZXoChk+7y8ZBIC2S0k2E+JkwQ1MNQqFWAAZKTAYYv FhcplTf0r+t9uBRT3SZdlUczUaBbEZ6ojAIStiSqYKWpPb+bGOyp2jY9Zsc4h/KcFKaw 6sl8dWSUzdVYg6yQcBpuALxgZrhSs6zLDzhi157qIWhaFBSMQGf5GfBzBKz3wECi4Y1r yTDctfsyOUoqZFSQWuUnTfTqjlyRCMIPreJ415LHlrAfKZv83mGtrh30MIM9cAvDNHDU k0Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=yKMmEygswSh+HSAhE4eO0vUK5Gb2tp6m+QiySpRhlDA=; b=o6yVwB4+Y+U7gbFSJelnSOiFrk6mf1xHvjoMD2SLok+aSQp6oDCn50+tu5uFhScniX 7fdLR+s4JbPptEe9TrDHpBZ+zfVHPeTQByPetBqkr6uu94g9Mwvw6NMoBWszNmMGaIaW uzedRgqcVA0BAC21m1USZ4gxSCX0V304l6BTCuYxhWcNQpM6QmPCW3EoCfOznifCf+Ke J0lTfea8DM0EDp+1jHQzbswA+b/y6PLDwxa0VDeRexDDO/9bHYt+FJ+ExsB6zi/EI9O1 WWChBDFx6xKPEo9qmNSUDzoChs1GUjOsLCUWN04OMGXuqZAj0op3TUNH3gMmS8ll4Bdf HVig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b="Ds/ExFhL"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p13si8891942edi.410.2019.10.07.01.00.16; Mon, 07 Oct 2019 01:00:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b="Ds/ExFhL"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727278AbfJGH7e (ORCPT + 99 others); Mon, 7 Oct 2019 03:59:34 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:44060 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726889AbfJGH7e (ORCPT ); Mon, 7 Oct 2019 03:59:34 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x977puUU029109; Mon, 7 Oct 2019 09:59:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=yKMmEygswSh+HSAhE4eO0vUK5Gb2tp6m+QiySpRhlDA=; b=Ds/ExFhLGTrIH1J+aJJ56QWtmGp0x6Yc2G8Vdx+0AJxoOhxNVt5Kbu1G7JgH+7yVtO7z fAC4+S8WSx6amgXdJOlV9e7eYYXgDzg7E+SHhoih6TNDHTkxSeexYpIasndpsnE5LUd9 WTpPDntqbG8RmEa15EzGDGtUYmz0AVQVJrTPMCq41dGt7m71Is5rfdZ/GlXDwv/gBJQX C1uIsv1gFjaQwc+p7ZJrbDCDzbAhMyHBuUYjWkqVBpC1z71lZDsCf3qQ+bSkNQlmL6/X Umr56fNHUFBPGFw11cXs8ANDPv1bDPuwHPzKioB5Syd0Ac/kOMEH/sHi6TywHuodFcDx 0A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2vej2p0ycj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Oct 2019 09:59:24 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2AB0610002A; Mon, 7 Oct 2019 09:59:24 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1E1DE2AF4DE; Mon, 7 Oct 2019 09:59:24 +0200 (CEST) Received: from [10.48.1.171] (10.75.127.45) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 7 Oct 2019 09:59:23 +0200 Subject: Re: [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1 To: Alain Volmat , CC: , , , , , References: <1570200954-17919-1-git-send-email-alain.volmat@st.com> From: Pierre Yves MORDRET Message-ID: Date: Mon, 7 Oct 2019 09:59:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1570200954-17919-1-git-send-email-alain.volmat@st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG3NODE3.st.com (10.75.127.9) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-07_01:2019-10-03,2019-10-07 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alain Fixes tag is missing in your patch. [ i.e ==> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") ] Nonetheless patch only consists in removing a comment character ? Thanks On 10/4/19 4:55 PM, Alain Volmat wrote: > Remove the following warning: > > drivers/i2c/busses/i2c-stm32f7.c:315: > warning: cannot understand function prototype: > 'struct stm32f7_i2c_spec i2c_specs[] = > > Signed-off-by: Alain Volmat > --- > drivers/i2c/busses/i2c-stm32f7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index d36cf08..7aa4a47 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -305,7 +305,7 @@ struct stm32f7_i2c_dev { > struct regmap *regmap; > }; > > -/** > +/* > * All these values are coming from I2C Specification, Version 6.0, 4th of > * April 2014. > * >