Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16
To:     Carlo Caione <carlo.caione@gmail.com>, linux-kernel@vger.kernel.org
Cc:     andrew.smirnov@gmail.com, rrangel@chromium.org,
        gregkh@linuxfoundation.org, kamal@canonical.com,
        khalid.elmously@canonical.com
References: <2f2f62bc-558f-70d1-44bf-a95334453f8a@gmail.com>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <294a9515-962a-d64b-c113-b73e9fe85fa8@linux.intel.com>
Date:   Mon, 7 Oct 2019 11:13:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <2f2f62bc-558f-70d1-44bf-a95334453f8a@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7.10.2019 10.21, Carlo Caione wrote:
> Hi,
> I bisected an issue down to commit f7fac17ca925 "xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()".
> 
> Setup:
> XPS 9370 + Thunderbolt dock Dell TB16
> 
> Issue:
> The laptop is unable to go to sleep. It never really goes to sleep and after a few seconds the USB dies.
> 
> Log:
> https://termbin.com/icix
> 
> Cheers!
> 

Does the below patch help?  Greg just applied it to his usb-linus branch.

ac343366846a xhci: Increase STS_SAVE timeout in xhci_suspend()
Link: https://lore.kernel.org/r/1570190373-30684-8-git-send-email-mathias.nyman@linux.intel.com

-Mathias