Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4169079ybp; Mon, 7 Oct 2019 04:27:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwpqqCmukrPNtpBL51K6kh7rTlLpXFmDNY/ui6M7jjoW/6H00zr/P27bhXMqUrMIBKLCl/o X-Received: by 2002:a17:906:e10a:: with SMTP id gj10mr23482169ejb.134.1570447653023; Mon, 07 Oct 2019 04:27:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570447653; cv=none; d=google.com; s=arc-20160816; b=ZwFno9mgXbePV9mJPp6Yi8CeEEz+61LWZAxgwGKVIojTcSQcSddS6uWdJdTXHgizet toWqfRWfCLdQuQcFXtkyFUztaN8IqY5v/j9qoCSyzRzQHf0Y9L8xqTGmq/V+mgJ+Uo6G OyTrcy1QPbCtuEEeZQsve/Aa+qVUeyOa7+XzEkOJYDFxZ/kk3fIqZtqEUe8A4kRnoA+q qgmiKPDUF+wn+UQfJedADnAHimh4H38tUeVNDTbBrOrOP3lkRE8HW7DuhYVTfgKhOD6/ lkP6l7gRozSZVvRieXNMVNDRCm6Y9Nxjn8MafnQo+6L5nCGCMa7RZDk8bgtDjwnPD9RC I0og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=8vVDGKAah49b3lLfauFQPDLoF6OEMW2lTmYVWqHvmsw=; b=qh5I0J4f7J3cAyhGdnDhrtiK0TsnkhG3rkrQZr1+QJBDdQIeDfJX6KjwKQ0T+03QuV 2xIcx3Mm9geXu30x5Fot3bO3EErWj8RUUCFdHB8oAx5vX8X62eXv3gREWyQvNNwVdISP 2O/FQcf8lQJ716nUCX5Klcp+TGiUX5gn4HlVdZTD8OMMUqwO17PwAxi4ReL1WOJMrQcC rV7uis9MKuGavNAHp2ilSHH7/hRP9Aolnd9ohU9zI3Uivp8j5vKwvuEqj+y1P9Jmozyp Z6eFyWc1g1FFAB6DMMiAF5QOs9jLbnqWo5CVKMlHkN9WI4pPKKs7CYzRPYqNWPTESzfW gFag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1si8024037ede.268.2019.10.07.04.27.09; Mon, 07 Oct 2019 04:27:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbfJGL00 (ORCPT + 99 others); Mon, 7 Oct 2019 07:26:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32238 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbfJGL00 (ORCPT ); Mon, 7 Oct 2019 07:26:26 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FE7A30B2502; Mon, 7 Oct 2019 11:26:26 +0000 (UTC) Received: from krava (unknown [10.43.17.61]) by smtp.corp.redhat.com (Postfix) with SMTP id C2C1660A35; Mon, 7 Oct 2019 11:26:24 +0000 (UTC) Date: Mon, 7 Oct 2019 13:26:24 +0200 From: Jiri Olsa To: Changbin Du Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] perf: add support for logging debug messages to file Message-ID: <20191007112624.GG6919@krava> References: <20191004023954.1116-1-changbin.du@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191004023954.1116-1-changbin.du@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 07 Oct 2019 11:26:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 04, 2019 at 10:39:52AM +0800, Changbin Du wrote: > When in TUI mode, it is impossible to show all the debug messages to > console. This make it hard to debug perf issues using debug messages. > This patch adds support for logging debug messages to file to resolve > this problem. > > v3: > o fix a segfault issue. heya, getting segfault for this: [jolsa@krava perf]$ ./perf report -vv 2>out Segmentation fault (core dumped) jirka > v2: > o specific all debug options one time. > > Changbin Du (2): > perf: support multiple debug options separated by ',' > perf: add support for logging debug messages to file > > tools/perf/Documentation/perf.txt | 15 ++-- > tools/perf/util/debug.c | 124 +++++++++++++++++++----------- > 2 files changed, 90 insertions(+), 49 deletions(-) > > -- > 2.20.1 >