Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4259990ybp; Mon, 7 Oct 2019 05:56:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtMslz3PZTLKcPA5Qh1mvlWc6gAAMRrRVNJuNOjQdX1EPW9PqUyRFHsUyp18hMG4JakTbw X-Received: by 2002:a17:906:6bca:: with SMTP id t10mr12818917ejs.64.1570452990276; Mon, 07 Oct 2019 05:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570452990; cv=none; d=google.com; s=arc-20160816; b=BnMEdLXFAensbNscET5gywKBzkL59DWk47aCrtQ6QWANryZAjnjixJRY2XKYM1rqys POFkEkTEKZ/iE7VGQZYm9OVxr8GaXZFNkIVo+J0cSiVVkPG9fv9hHyD8yoSQQKvx7TyR VslgfzThgjkgbageFnd1M7m0Xgx3OvXnpE0i0yWS4Yng8fi4cUXXie4/gjHJL1DFcoEK dq/Df1mLPzt6qKuqdQIWyuXlvSemGEYKGd9aHxeN/wbhxwgwFs3Q7VeMwd85/a7bPB5A XMYKgxPvBU8vMiix7CmS6VSKB/ZFHVNhEKGkO37BdaPZn9VLycuQCDT4NKZ8JPg9q+RS xh3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3d9R8ySPPGWEIws0tXmkZAGWWZbpIwdvhGUVJ6rGXfc=; b=x/P5WmIiGArO7qxtxSeil04MeyErCnZnRYtMHmcaV4fze3DUzV4UuO64LAKPH0Z5hJ b5zNkXUlc8tGSy6FyOmTBwe3DL1ziOMdUaD8ey3Yf3rbNVktOyRYLpralmSiuYw2kwYn u4neV4qZPyrJNFPaNXDetNQCb1sI+uYY2tRs3rhbJ+8zVBFHfQiFDZS8xfd+Vnq1JAUr d9QhyVpNQEmGDIADVJ39WzEfKdYK0MYA/FMODvphejdd3OyTwCAM7OpkInfC68qkkpoE I7FC3NiURzETEW0TIXTFjd2MlQXhwXmyMb+MqGL/qVtfj7uHKGbWfj89stXX3EnPSjyf RnVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qn13si6966967ejb.114.2019.10.07.05.56.06; Mon, 07 Oct 2019 05:56:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728546AbfJGMzL (ORCPT + 99 others); Mon, 7 Oct 2019 08:55:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728542AbfJGMzJ (ORCPT ); Mon, 7 Oct 2019 08:55:09 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EDCC7316D797; Mon, 7 Oct 2019 12:55:08 +0000 (UTC) Received: from krava.brq.redhat.com (unknown [10.43.17.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id 523F35D9CC; Mon, 7 Oct 2019 12:55:07 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan Subject: [PATCH 35/36] libperf: Do not export perf_evsel__init/perf_evlist__init Date: Mon, 7 Oct 2019 14:53:43 +0200 Message-Id: <20191007125344.14268-36-jolsa@kernel.org> In-Reply-To: <20191007125344.14268-1-jolsa@kernel.org> References: <20191007125344.14268-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 07 Oct 2019 12:55:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no point to export perf_evsel__init/perf_evlist__init, it's called from perf_evsel__new/perf_evlist__new respectively. It's used only from perf where perf_evsel/perf_evlist is embedded perf's evsel/evlist. Link: http://lkml.kernel.org/n/tip-k0w3i2vqos0lvnadfm95a8fy@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/lib/include/internal/evlist.h | 1 + tools/perf/lib/include/internal/evsel.h | 1 + tools/perf/lib/include/perf/evlist.h | 1 - tools/perf/lib/include/perf/evsel.h | 2 -- tools/perf/lib/libperf.map | 2 -- 5 files changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/perf/lib/include/internal/evlist.h b/tools/perf/lib/include/internal/evlist.h index 513a85cb7bfe..450dacdfc062 100644 --- a/tools/perf/lib/include/internal/evlist.h +++ b/tools/perf/lib/include/internal/evlist.h @@ -50,6 +50,7 @@ int perf_evlist__mmap_ops(struct perf_evlist *evlist, struct perf_evlist_mmap_ops *ops, struct perf_mmap_param *mp); +void perf_evlist__init(struct perf_evlist *evlist); void perf_evlist__exit(struct perf_evlist *evlist); /** diff --git a/tools/perf/lib/include/internal/evsel.h b/tools/perf/lib/include/internal/evsel.h index a69b8299c36f..1ffd083b235e 100644 --- a/tools/perf/lib/include/internal/evsel.h +++ b/tools/perf/lib/include/internal/evsel.h @@ -50,6 +50,7 @@ struct perf_evsel { bool system_wide; }; +void perf_evsel__init(struct perf_evsel *evsel, struct perf_event_attr *attr); int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads); void perf_evsel__close_fd(struct perf_evsel *evsel); void perf_evsel__free_fd(struct perf_evsel *evsel); diff --git a/tools/perf/lib/include/perf/evlist.h b/tools/perf/lib/include/perf/evlist.h index 8c4b3c28535e..0a7479dc13bf 100644 --- a/tools/perf/lib/include/perf/evlist.h +++ b/tools/perf/lib/include/perf/evlist.h @@ -10,7 +10,6 @@ struct perf_evsel; struct perf_cpu_map; struct perf_thread_map; -LIBPERF_API void perf_evlist__init(struct perf_evlist *evlist); LIBPERF_API void perf_evlist__add(struct perf_evlist *evlist, struct perf_evsel *evsel); LIBPERF_API void perf_evlist__remove(struct perf_evlist *evlist, diff --git a/tools/perf/lib/include/perf/evsel.h b/tools/perf/lib/include/perf/evsel.h index 4388667f265c..557f5815a9c9 100644 --- a/tools/perf/lib/include/perf/evsel.h +++ b/tools/perf/lib/include/perf/evsel.h @@ -21,8 +21,6 @@ struct perf_counts_values { }; }; -LIBPERF_API void perf_evsel__init(struct perf_evsel *evsel, - struct perf_event_attr *attr); LIBPERF_API struct perf_evsel *perf_evsel__new(struct perf_event_attr *attr); LIBPERF_API void perf_evsel__delete(struct perf_evsel *evsel); LIBPERF_API int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus, diff --git a/tools/perf/lib/libperf.map b/tools/perf/lib/libperf.map index 8be02afc324b..7be1af8a546c 100644 --- a/tools/perf/lib/libperf.map +++ b/tools/perf/lib/libperf.map @@ -21,7 +21,6 @@ LIBPERF_0.0.1 { perf_evsel__delete; perf_evsel__enable; perf_evsel__disable; - perf_evsel__init; perf_evsel__open; perf_evsel__close; perf_evsel__read; @@ -34,7 +33,6 @@ LIBPERF_0.0.1 { perf_evlist__close; perf_evlist__enable; perf_evlist__disable; - perf_evlist__init; perf_evlist__add; perf_evlist__remove; perf_evlist__next; -- 2.21.0