Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Nathan Chancellor' <natechancellor@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
CC:     Christian Brauner <christian.brauner@ubuntu.com>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: RE: [GIT PULL] usercopy structs for v5.4-rc2
Thread-Topic: [GIT PULL] usercopy structs for v5.4-rc2
Thread-Index: AQHVeuwFcYhVK5e8z06Z1VFXvM2TfadPKxGQ
Date:   Mon, 7 Oct 2019 13:11:46 +0000
Message-ID: <d0944174abe24165ac5cb63c52b89c42@AcuMS.aculab.com>
References: <20191004104116.20418-1-christian.brauner@ubuntu.com>
 <CAHk-=whxf5HVdaXqL6RgHCLzb2LNn3U2n_x4GWQZroCC+evRoA@mail.gmail.com>
 <20191004194330.GA1478788@archlinux-threadripper>
In-Reply-To: <20191004194330.GA1478788@archlinux-threadripper>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Nathan Chancellor
> Sent: 04 October 2019 20:44
...
> > IOW, the code should have just been
> >
> >         ret = test(umem_src == NULL, "kmalloc failed");
> >         if (ret) ...
> 
> Yes, I had this as the original fix but I tried to keep the same
> intention as the original author. I should have gone with my gut. Sorry
> for the ugliness, I'll try to be better in the future.

This rather begs the question about why 'usercopy' is ever calling kmalloc() at all.
Never mind some perverted style for reporting errors.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)