Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4407823ybp; Mon, 7 Oct 2019 08:04:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqzToQHJCK7s4tc6W0Er5+u4de43b4O6vHSZhnXNqOhVT3svnKvNzI0d0aM6YMi1hqL5i4JO X-Received: by 2002:adf:f18a:: with SMTP id h10mr12989652wro.164.1570460642807; Mon, 07 Oct 2019 08:04:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570460642; cv=none; d=google.com; s=arc-20160816; b=rP97o1krabmrRSZ28RI7zGZG5Qt3SEykBtqS4mXVFbvorVl4CmV4M4AamtoRcnF15E epH3WYBUi5ycPL6VNbQ8GRpBVNtAysVaN+chyOibMdOZEBJcJ5IbPIRRxILIzQFDQFqd NQ25ytG7fOWivokfaKqbPMbvfRhyd65di7GMXYQjNGBrgE7XyIKSkF22YBuo25TWhgOJ y2LhOFYl/6/+LgmabwB8sanxj32XO4prZKznb+rqIgcCCC7sz1hzD9zvaZakRra7wqBf RLD8ZS1A98BZNMY57ZVhlvFyofBI6Fv9s8iRRYe6QmWS8Big2LmEfxY443Dwg7w8BDOJ 2PPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:mail-followup-to:reply-to:message-id:subject:cc:to:from :date; bh=8ue3XpdSma0wJwvX4awDLlIRi2ZscQzmnZP2ldS6fEY=; b=YaB4EgKxy4hdFvmVZ2MFUdXk5ueZCU9wH+NUZNxU/cMm3ym/jLg8MEPhCvnGp/ohHX YW7h3usD/AtzNfn/aEn/pZGpgNQb+pect5ERKcanFu7NFIqVpy6gdYZM9Gifc/u95PXo kuvYR8s4At8C/mhlidVj9A6LHrRDA4eePnDhFR5d09WTPIJ2I98cFVDHHMyV9FTH6Vkc YiWILUNT2ehgcJiEbvj4Yw+ZrN5ZuDMWMBVyhbUGC9XCxoGhKNa1jJzQlEw8VjoSI1eN NEe70GgLrJVPcqSmnV+aAOurH6XJW449yUPrGdJH8i71AtPiSz0XqegnotJr/xuw6fOk oKhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qp4si7709974ejb.171.2019.10.07.08.03.37; Mon, 07 Oct 2019 08:04:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728130AbfJGPD3 (ORCPT + 99 others); Mon, 7 Oct 2019 11:03:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:34038 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727490AbfJGPD3 (ORCPT ); Mon, 7 Oct 2019 11:03:29 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7C14BACD8; Mon, 7 Oct 2019 15:03:27 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id F1B4BDA7FB; Mon, 7 Oct 2019 17:03:41 +0200 (CEST) Date: Mon, 7 Oct 2019 17:03:40 +0200 From: David Sterba To: Austin Kim Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: fix Wmaybe-uninitialized warning Message-ID: <20191007150340.GA2751@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Austin Kim , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190903033019.GA149622@LGEARND20B15> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190903033019.GA149622@LGEARND20B15> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 12:30:19PM +0900, Austin Kim wrote: > gcc throws warning message as below: > > ‘clone_src_i_size’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) > ^ > fs/btrfs/send.c:5088:6: note: ‘clone_src_i_size’ was declared here > u64 clone_src_i_size; > ^ > The clone_src_i_size is only used as call-by-reference > in a call to get_inode_info(). > > Silence the warning by initializing clone_src_i_size to 0. > > Signed-off-by: Austin Kim A few more people have repoted this warning, so I'm gonig to apply the patch to avoid further reports. Thanks.