Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 7 Oct 2019 08:23:36 -0700
From:   "Darrick J. Wong" <darrick.wong@oracle.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] iomap: add tracing for the readpage / readpages
Message-ID: <20191007152336.GS13108@magnolia>
References: <20191006154608.24738-1-hch@lst.de>
 <20191006154608.24738-2-hch@lst.de>
 <20191006224324.GR13108@magnolia>
 <20191007054838.GA15655@lst.de>
 <20191007061705.GA20377@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191007061705.GA20377@lst.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 07, 2019 at 08:17:05AM +0200, Christoph Hellwig wrote:
> On Mon, Oct 07, 2019 at 07:48:38AM +0200, Christoph Hellwig wrote:
> > On Sun, Oct 06, 2019 at 03:43:24PM -0700, Darrick J. Wong wrote:
> > > > +iomap-y				+= trace.o \
> > > 
> > > I think this patch is missing fs/iomap/trace.c ?
> > 
> > It does.  The file is in my tree, but I never did a git-add for it..
> 
> A branch with the file is here:
> 
>    git://git.infradead.org/users/hch/xfs.git iomap-writepage.7
> 
> Gitweb:
> 
>     http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/iomap-writepage.7
> 
> I'll wait a bit until I resend to see if people find other issues.

I didn't see any, at least not in a quick overnight fstests run.

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D