Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4449314ybp; Mon, 7 Oct 2019 08:36:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3tkeAz6dv1ChsrRx3iXCeO7fcSj07IFjZ7s81g80X1sYhx6NbsDDiAhIo/qJP5ut06QXY X-Received: by 2002:a50:f616:: with SMTP id c22mr29004571edn.235.1570462568167; Mon, 07 Oct 2019 08:36:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570462568; cv=none; d=google.com; s=arc-20160816; b=B0RCmgaMU0iBJJk8HxqjNz8HYLzShzQpT/krKJZUmHKLUc9/2wz6+nycukJQnp78zo 4JX5Ez9eUEjCWqZBFAo8wHILf+uTWE3x3NPLS4fMagtO3Ocu8624BnLKHYzxer+Iq3G2 2KbNg6H7zyxRmskPQ9LlZagBIOFtzwtcHmkoCqm+asWpKWN2fiVb2uEpDJ/kknxTDAQA APKNyDVAjxpaqpNLalvU19gF7woc18OmBQRXpNNXtpT75ywS4WCTza2iPxvbVzQLFFD7 0Wml0SEqs2ynbYZS4VeDadPwg+SEcLkB8zT9MHqlYaaKi/RbDnDhSIbht7efNch4gk7A +41Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:subject:cc:to:from :references:in-reply-to:content-transfer-encoding:mime-version :message-id:dkim-signature; bh=9grFCI4XfO/P0ws+W1hJ+qqcKoeFDoYdqOk/sFE2nys=; b=mFRJ3AsQH7j2MNfZ9fjqO/U1eaLWTAinnA7nu919rQUmV6pjYaynrCJsVPsgrQFKxb ZCJf7s2nZQdBUz0X5Tl1T+Msbz/Nhx+BKe+lSnn8ejjzjtc9nGPsOqVkw+4CNEmwkQ97 OXHwMZP3kI7tRis6/ANmeX0k1wQybw22qBltTpkvAh4V6GHMzybs34WQNiTh07DQigBL MI7YwI7B++0ofI5D+8T3x4nyjuQbX4clHk/VjI3HDAqeuG1JdO37oOtvh58UCUfX1nlg DUq4W7LrV+XTgmGrhokPCReoNC9uYo6fvxF3CdjyEpr3cN/mH4a/sq8w5wf4eq/RPxxy lB8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aMLKJPZS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si7181005eje.339.2019.10.07.08.35.44; Mon, 07 Oct 2019 08:36:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aMLKJPZS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728081AbfJGPf3 (ORCPT + 99 others); Mon, 7 Oct 2019 11:35:29 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45502 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727745AbfJGPf3 (ORCPT ); Mon, 7 Oct 2019 11:35:29 -0400 Received: by mail-pg1-f193.google.com with SMTP id q7so8406328pgi.12 for ; Mon, 07 Oct 2019 08:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:from:to:cc:subject:user-agent:date; bh=9grFCI4XfO/P0ws+W1hJ+qqcKoeFDoYdqOk/sFE2nys=; b=aMLKJPZSjvPLIvvPUOcLneGm6UxCTtoLtzu9ffcLbVXvDidM8JuF1e+MVb3sIS65Rq U+WAA8O0CjIgP1SVdukQJ1n7LhU5IDHRkmgOsXRbwgbLurkHtpICBk6CDY5zOBvJOuKG Uk12yc1LHvoAeGZUh/7hlz1jJKzEGxP+syK4A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:from:to:cc:subject :user-agent:date; bh=9grFCI4XfO/P0ws+W1hJ+qqcKoeFDoYdqOk/sFE2nys=; b=ZNgyt15msEAvXtbwdFK07PEBEqsR9kI8Ii91caUbYguUdvtROWKV26Lmfr4SX73N85 uCG5+GZ9H7ncyuDFmmw70uIdYPk7dv1kWMm3gGJucEejfw6WtS6s0cLLsDH1Gb3gOo2z P4cu531rG17QmBUOVVDN4E/AFrfGbVBgVYmTPwW1VjySjZJPpMgPd5v/Qjv3dMCsblxk SrSRk2yINpOn3x8gu/MR1RkUWvUOYX7SkXNaFJbZGdPuVWiHeKkepFPnBHV8KiF2saVk uC7YpZdTArI85x+qejGef6u2/VyFn/ckdahO0r/WiStFyf6TLbKQ2IugfxS/cjVEIo1c mngw== X-Gm-Message-State: APjAAAU6zoOjZ2ej9Jeylsd7QeM0xevLpTB4EZO207VRkd7I9sCjQJOA uJ0JMwYMl/wWxLxaWONRL6sqRw== X-Received: by 2002:a65:6644:: with SMTP id z4mr4897044pgv.208.1570462527521; Mon, 07 Oct 2019 08:35:27 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id i1sm15674482pfg.2.2019.10.07.08.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 08:35:26 -0700 (PDT) Message-ID: <5d9b5b3e.1c69fb81.7203c.1215@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20191007071610.65714-1-cychiang@chromium.org> From: Stephen Boyd To: Cheng-yi Chiang , Guenter Roeck Cc: Tzung-Bi Shih , Linux Kernel Mailing List , ALSA development , Hung-Te Lin , Greg Kroah-Hartman , Sean Paul , Mark Brown , Dylan Reid , Tzung-Bi Shih , Srinivas Kandagatla Subject: Re: [PATCH] firmware: vpd: Add an interface to read VPD value User-Agent: alot/0.8.1 Date: Mon, 07 Oct 2019 08:35:25 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Cheng-yi Chiang (2019-10-07 06:58:41) >=20 > Hi Guenter, > Thanks for the quick review. > I'll update accordingly in v2. I'd prefer this use the nvmem framework which already handles many of the requirements discussed here. Implement an nvmem provider and figure out how to wire that up to the kernel users. Also, please include a user of the added support, otherwise it is impossible to understand how this code is used.