Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191006184515.23048-1-jcfaracco@gmail.com> <20191006184515.23048-3-jcfaracco@gmail.com>
 <20191007034402-mutt-send-email-mst@kernel.org> <CAENf94L+KNJgq1V6kgcwnT0hyTZMDX5Jh6kYRCaeMHDU4GGHCg@mail.gmail.com>
In-Reply-To: <CAENf94L+KNJgq1V6kgcwnT0hyTZMDX5Jh6kYRCaeMHDU4GGHCg@mail.gmail.com>
From:   Julio Faracco <jcfaracco@gmail.com>
Date:   Mon, 7 Oct 2019 13:03:34 -0300
Message-ID: <CAENf94Kamcd4TSy4wLGWLVCESiZr6q9+Kj2+3TFbFy2XncXOOw@mail.gmail.com>
Subject: Re: [PATCH RFC net-next 2/2] drivers: net: virtio_net: Add tx_timeout function
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     netdev@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
        davem@davemloft.net, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Daiane Mendes <dnmendes76@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em seg, 7 de out de 2019 =C3=A0s 11:03, Julio Faracco <jcfaracco@gmail.com>=
 escreveu:
>
> Em seg, 7 de out de 2019 =C3=A0s 04:51, Michael S. Tsirkin <mst@redhat.co=
m> escreveu:
> >
> > On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco@gmail.com wrote:
> > > From: Julio Faracco <jcfaracco@gmail.com>
> > >
> > > To enable dev_watchdog, virtio_net should have a tx_timeout defined
> > > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. I=
t
> > > notifies the event in some specific queue of device. This function
> > > still counts tx_timeout statistic and consider this event as an error
> > > (one error per queue), reporting it.
> > >
> > > Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
> > > Signed-off-by: Daiane Mendes <dnmendes76@gmail.com>
> > > Cc: Jason Wang <jasowang@redhat.com>
> > > ---
> > >  drivers/net/virtio_net.c | 27 +++++++++++++++++++++++++++
> > >  1 file changed, 27 insertions(+)
> > >
> > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > index 27f9b212c9f5..4b703b4b9441 100644
> > > --- a/drivers/net/virtio_net.c
> > > +++ b/drivers/net/virtio_net.c
> > > @@ -2585,6 +2585,29 @@ static int virtnet_set_features(struct net_dev=
ice *dev,
> > >       return 0;
> > >  }
> > >
> > > +static void virtnet_tx_timeout(struct net_device *dev)
> > > +{
> > > +     struct virtnet_info *vi =3D netdev_priv(dev);
> > > +     u32 i;
> > > +
> > > +     /* find the stopped queue the same way dev_watchdog() does */
> >
> > not really - the watchdog actually looks at trans_start.
>
> The comments are wrong. It is the negative logic from dev_watchdog.
> Watchdog requires queue stopped AND timeout.
>
> If the queue is not stopped, this queue does not reached a timeout event.
> So, continue... Do not report a timeout.
>
> >
> > > +     for (i =3D 0; i < vi->curr_queue_pairs; i++) {
> > > +             struct send_queue *sq =3D &vi->sq[i];
> > > +
> > > +             if (!netif_xmit_stopped(netdev_get_tx_queue(dev, i)))
> > > +                     continue;
> > > +
> > > +             u64_stats_update_begin(&sq->stats.syncp);
> > > +             sq->stats.tx_timeouts++;
> > > +             u64_stats_update_end(&sq->stats.syncp);
> > > +
> > > +             netdev_warn(dev, "TX timeout on send queue: %d, sq: %s,=
 vq: %d, name: %s\n",
> > > +                         i, sq->name, sq->vq->index, sq->vq->name);
> >
> > this seems to assume any running queue is timed out.
> > doesn't look right.
> >
> > also - there's already a warning in this case in the core. do we need a=
nother one?
>
> Here, it can be a debug message if the idea is enhance debugging informat=
ion.
> Other enhancements can be done to enable or disable debug messages.
> Using ethtool methods for instance.

Observation...
Another important point, kernel will thrown WARN_ONCE, only if
ndo_tx_timeout() is implemented.
Even if we are adding an extra/unnecessary netdev_warn() we need this
function to enable dev_watchdog().

>
> >
> > > +             dev->stats.tx_errors++;
> >
> >
> >
> > > +     }
> > > +}
> > > +
> > >  static const struct net_device_ops virtnet_netdev =3D {
> > >       .ndo_open            =3D virtnet_open,
> > >       .ndo_stop            =3D virtnet_close,
> > > @@ -2600,6 +2623,7 @@ static const struct net_device_ops virtnet_netd=
ev =3D {
> > >       .ndo_features_check     =3D passthru_features_check,
> > >       .ndo_get_phys_port_name =3D virtnet_get_phys_port_name,
> > >       .ndo_set_features       =3D virtnet_set_features,
> > > +     .ndo_tx_timeout         =3D virtnet_tx_timeout,
> > >  };
> > >
> > >  static void virtnet_config_changed_work(struct work_struct *work)
> > > @@ -3018,6 +3042,9 @@ static int virtnet_probe(struct virtio_device *=
vdev)
> > >       dev->netdev_ops =3D &virtnet_netdev;
> > >       dev->features =3D NETIF_F_HIGHDMA;
> > >
> > > +     /* Set up dev_watchdog cycle. */
> > > +     dev->watchdog_timeo =3D 5 * HZ;
> > > +
> >
> > Seems to be still broken with napi_tx =3D false.
> >
> > >       dev->ethtool_ops =3D &virtnet_ethtool_ops;
> > >       SET_NETDEV_DEV(dev, &vdev->dev);
> > >
> > > --
> > > 2.21.0