Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4719150ybp; Mon, 7 Oct 2019 12:50:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqy2XxgFx11oz5akrzIFMA1NXGB06POW7dmbMdiiRHHQA1Q21/68o2mBUg/RMoK27/4F51f7 X-Received: by 2002:a50:979b:: with SMTP id e27mr29820873edb.173.1570477805708; Mon, 07 Oct 2019 12:50:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570477805; cv=none; d=google.com; s=arc-20160816; b=NRYfhpKtqpEON9YyEC72X2C2xC1DEXF0UG02d0p8t8lCkLvpU45tVIaAzvewiAYNZJ a7QVPPNcA4UWes5lQD0FEXZbSJKo1U7BAGdLF2gUfUL35aW+NyKr0qNOU+SO5ZPl1Dt2 KVqKj3EPetyKJlOURP/U1DG4F1ms5qvIbzwFv1quDuHyePuBbWP8k/GW3EJNlCk9R0al 9Va1qpO+h2opUsyMwazbiMzaJesk+5eyA5AG0Yc6rBpcQybF/detgw6Il+NRw3tSjgig YZUCr/tGQSGgEN2EP52rf+ro37MGU80fGotvhGqeJ4N2IQ6K57G7ko8ftA0nM4/fCTe8 bMMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=hKLRuow+S9OqCZD+ZwnXS5BKikj0oOH26JZuOKs1SBc=; b=TLr2VpbJ8TLsOwhZZZEXVnWQ5lP5/BFjr1k4h4dKXld30mkueeeMZrllr9RwD15bI5 /MK23qplIunnpz5xed3YUTKpdsJnj1dLxp2ynIPXcqiWABPfXdMTQ0aNLtOQk6H7xWTJ akNS6Yaf2sC1L0Z1bwkq26iycu0mL0FmkXznQ/4AHCS7NOI2aHkHV1CYeL6FDXZDABcK KglZE/EXAcVslOCujI6ls33pzF8pDHunjkq3RUpg4jxplPKH3g807oraZu5bv0XjgwGD NS+VlIz/B0Ya98ejEnFdZkEi2/p8K828OzCP6LYMUlafDPg1+TJ9c0nqQwrRv2e2koat TxZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MWQHgu8L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x17si7467502ejw.375.2019.10.07.12.49.42; Mon, 07 Oct 2019 12:50:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MWQHgu8L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728792AbfJGTtb (ORCPT + 99 others); Mon, 7 Oct 2019 15:49:31 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:39155 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728187AbfJGTtb (ORCPT ); Mon, 7 Oct 2019 15:49:31 -0400 Received: by mail-qt1-f196.google.com with SMTP id n7so21004293qtb.6; Mon, 07 Oct 2019 12:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hKLRuow+S9OqCZD+ZwnXS5BKikj0oOH26JZuOKs1SBc=; b=MWQHgu8Lz7xXr6b3L0k+K5jZEIYjkw/PzSJnogPsH4dvevuA4viSxuR3XyJJLMTU3s evwiIbB1wBE/1qzIo3U6Qn6WgHlmV1cBIG1GN1zrY73xpHCiS13oGNT/BeWRjR5fF2NM HpRGtFRJBABpbaZZznvfaV/D/qITCU1cBdcg99QA67L1CS4uNepyE2CKIWuqgwnSJUC8 zCmMVXX1mxBsNSGcuOB7Wa+MXTsWyITwS6fqtcPWSClHvApLJGQkt++jYbmF5CgSh/bj 5U4nGmRMJWCv5DOSAlRmiUW6qVUzqSQWhKS1ULlg1mTc6veg+nhUFqr+J/mkFyYcff1Y w/cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hKLRuow+S9OqCZD+ZwnXS5BKikj0oOH26JZuOKs1SBc=; b=GqBR7YaAPivnVDn+TKJpKbZ+jIv6d8Y0IKFKutRC4UHfgpcWq7rVBmr77Z3DOm0BMG hyJOE3cgmR60Ba86UkTb0xQA0ywmc0ngsi0jFuBEpZs12LESOUHdRGOvYxr3bcmv9iSA q00NPTlGeYqc2RGtGLSAq+t8WVf+vM3luy0nc4vJ9QWVdMR2vlYhflYbC1/u5v1LXMes Q0Dt76S6HLUf7pGJAK/MUXrEbwpDqfqNK/Pnkdh8brHwvyTQOtK0Souqwk7MhFjOetUm pYgoVA1sRteVgP2GzkZB7bVw91sqRJ2n8JlXuxFj403KCngDINSd4cJRhe52y+IRPSAL geNg== X-Gm-Message-State: APjAAAVK5RCg6gqfiuxZGQ2M5pfyP1ENoaoArpWgLHKuOQRvK/KXo79H it0lXpjoAHPSaNzmDY3RZ8mbkyRcK1i7KgG5+NJC+B/B X-Received: by 2002:ad4:42c8:: with SMTP id f8mr28230703qvr.94.1570477770597; Mon, 07 Oct 2019 12:49:30 -0700 (PDT) MIME-Version: 1.0 References: <20191006222046.GA18027@roeck-us.net> <5f06c138-d59a-d811-c886-9e73ce51924c@roeck-us.net> <20191007012437.GK26530@ZenIV.linux.org.uk> <20191007025046.GL26530@ZenIV.linux.org.uk> In-Reply-To: From: Tony Luck Date: Mon, 7 Oct 2019 12:49:19 -0700 Message-ID: Subject: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user() To: Linus Torvalds Cc: Al Viro , Guenter Roeck , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 7, 2019 at 12:09 PM Linus Torvalds wrote: > Hmm? I thought ia64 did unaligneds ok. If PSR.ac is set, we trap. If it isn't set, then model specific (though all implementations will trap for an unaligned access that crosses a 4K boundary). Linux sets PSR.ac. Applications can use prctl(PR_SET_UNALIGN) to choose whether they want the kernel to silently fix things or to send SIGBUS. Kernel always noisily (rate limited) fixes up unaligned access. Your patch does make all the messages go away. Tested-by: Tony Luck