Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     =?iso-8859-1?Q?Michal_Koutn=FD?= <mkoutny@suse.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "tj@kernel.org" <tj@kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] cgroup, blkcg: prevent dirty inodes to pin dying memory
 cgroups
Thread-Topic: [PATCH] cgroup, blkcg: prevent dirty inodes to pin dying memory
 cgroups
Thread-Index: AQHVewChQOAw+GKbfEyRn45Yoe7HH6dPX/gAgAB214A=
Date:   Mon, 7 Oct 2019 23:24:51 +0000
Message-ID: <20191007232447.GA11171@tower.DHCP.thefacebook.com>
References: <20191004221104.646711-1-guro@fb.com>
 <20191007161925.GA23403@blackbody.suse.cz>
In-Reply-To: <20191007161925.GA23403@blackbody.suse.cz>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::3:2a00]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d2ee4345-4bd0-4295-5ff5-08d74b7d8d8a
x-ms-traffictypediagnostic: BN8PR15MB2947:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR15MB294769FAA2F9A84BACC78974BE9B0@BN8PR15MB2947.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 01834E39B7
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(136003)(39860400002)(346002)(396003)(366004)(199004)(189003)(486006)(186003)(99286004)(66446008)(476003)(8936002)(6116002)(6436002)(66476007)(46003)(66556008)(9686003)(5024004)(66946007)(64756008)(81156014)(81166006)(6512007)(4326008)(256004)(11346002)(6506007)(386003)(76176011)(54906003)(446003)(33656002)(52116002)(478600001)(102836004)(25786009)(6246003)(8676002)(316002)(7736002)(305945005)(71200400001)(229853002)(71190400001)(5660300002)(14454004)(86362001)(1076003)(6916009)(2906002)(6486002)(14143004);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR15MB2947;H:BN8PR15MB2626.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: dK+22BOqsL3MfyuiOvMD2lo0YayDSAFhisQabpqb5m6Pp36ALDcAiHvGy8KIL2l0y5Hqc9of3utdUJIgIP1q6ubliZJEQq/PJT/X/7WMwupT/iwYpcvkt2oIC4bpk2UYId9EnSfo8Ekfhu1EwxVRXNBx3/+sYQfBJ75gYsTxfu/LXlbmbxMDTBjfX6U8d/cBbqlLfHXnoC6O6mRQff6oSIh/C6O3uAbh0ni4F4jpCVurMWdqmCWgW6JaOs3DowHksg5k5bHusk3tKqYZTZyVqGmrbTUdEK1yvEOJZrox6STkr0B3ZPGIPwS5LpvNtE06sYdZOVyasLwEtDXWwAHfrdaURYwVRH4K0o2oiZfzdsPCafCO0BQjJ/U4tP/LmCIVqvghusrBdMkI0xmB6VGWApCs5T8FkV9oHi5ALgSZB5A=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <E1AE8D1D549C9047873D0CFFD6B6C634@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d2ee4345-4bd0-4295-5ff5-08d74b7d8d8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2019 23:24:52.0581
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FTmMd1D1g8/FpZIF5kk8hBSuvhgi3KavxN7onYhrjO6ZyM1OJIgRJn3Fl9Z2wXDA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2947
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-07_04:2019-10-07,2019-10-07 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0
 priorityscore=1501 mlxlogscore=741 clxscore=1015 spamscore=0 phishscore=0
 bulkscore=0 impostorscore=0 suspectscore=0 mlxscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1910070209
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 07, 2019 at 06:19:26PM +0200, Michal Koutn=FD wrote:
> On Fri, Oct 04, 2019 at 03:11:04PM -0700, Roman Gushchin <guro@fb.com> wr=
ote:
> > An inode which is getting dirty for the first time is associated
> > with the wb structure (look at __inode_attach_wb()). It can later
> > be switched to another wb under some conditions (e.g. some other
> > cgroup is writing a lot of data to the same inode), but generally
> > stays associated up to the end of life of the inode structure.
> What about dissociating the wb structure from the charged cgroup after
> the particular writeback finished? (I understand from your description
> that wb structure outlives the dirtier and is kept due to other inode
> (read) users, not sure if that's correct assumption.)

Well, that sounds nice, and I thought into this direction, but I've no idea
how to implement it :)

First, it's hard to find a good moment for dissociation. It seems that
the good moment is after the cgroup has been removed by the user and most
of the dirty memory has been written back, but it's hard to formalize,
given that other cgroups may write to the same inode concurrently.

Second, the current code assumes that wb->memcg association never breaks,
and it's not that trivial to get rid of this assumption without
introducing new locks, etc.

Thanks!