Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "tj@kernel.org" <tj@kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] cgroup, blkcg: prevent dirty inodes to pin dying memory
 cgroups
Thread-Topic: [PATCH] cgroup, blkcg: prevent dirty inodes to pin dying memory
 cgroups
Thread-Index: AQHVewChQOAw+GKbfEyRn45Yoe7HH6dPSQKAgACQ1oA=
Date:   Mon, 7 Oct 2019 23:35:43 +0000
Message-ID: <20191007233539.GC11171@tower.DHCP.thefacebook.com>
References: <20191004221104.646711-1-guro@fb.com>
 <f12d0a39-b7ef-39f9-3ff7-412c2d36aaac@suse.cz>
In-Reply-To: <f12d0a39-b7ef-39f9-3ff7-412c2d36aaac@suse.cz>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::3:2a00]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5d2cbed6-d647-4fb5-b010-08d74b7f1250
x-ms-traffictypediagnostic: BN8PR15MB2946:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR15MB2946565B07F7FB7FEA96EC47BE9B0@BN8PR15MB2946.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 01834E39B7
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(396003)(39860400002)(366004)(376002)(346002)(199004)(189003)(54094003)(386003)(316002)(6506007)(6916009)(54906003)(486006)(53546011)(52116002)(76176011)(476003)(11346002)(446003)(46003)(102836004)(2906002)(71200400001)(71190400001)(6116002)(86362001)(186003)(66446008)(66946007)(66476007)(66556008)(64756008)(6436002)(9686003)(6512007)(6486002)(229853002)(7736002)(305945005)(4326008)(14444005)(99286004)(8936002)(81166006)(8676002)(81156014)(256004)(1076003)(14454004)(5660300002)(25786009)(478600001)(33656002)(6246003)(14143004);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR15MB2946;H:BN8PR15MB2626.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BXXuIp7lriX5zSLgXXbzpcyC+DyrNOy6uUA7y3Bxtkt919JA4nLhmKLujIZbUOSPFv59R4Q5yUOI699UNP4v7DsmJCSvKI3WDEGAWJKKJQ6CZ3yxPmKu/BCm8GamlEZ7efswIUPv1q8BB+0hoagbdSRUXAaxm4cpFg5moKAD2/IbGKGmBKkKKMw8kkR/Tr3KX6MUHvsfKQr+RjEOPrUBJBhJ4UeL4gvNOsU1yBSs11oMMsklwR2i59YIMnhWED6S+Fg5I0VRlkTT3u/5BL4XrwxakCR4nGHZvEVyWhk563S48Kcf1AZn2M4r0jd0RO4kYGsOG5g1T6d2R7NIhvMtcVGjBZMIySNLbKMPuxXYCaNOc/DUac2Do0lnH8+ADAQ+VH76e4Ed8sedYM6OulaNgK8thHC4bMBifnJwfSThoiY=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28F922B8B34A0C4D9800A6E1552519F0@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d2cbed6-d647-4fb5-b010-08d74b7f1250
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2019 23:35:43.8510
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 13nwpEN+ppN9SedQGJJs5e7YZ7I498aeKap2yYnXFb/RvFW/1EzcgH4k4jm870Hu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2946
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-07_04:2019-10-07,2019-10-07 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 mlxlogscore=883
 lowpriorityscore=0 spamscore=0 mlxscore=0 phishscore=0 impostorscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1910070211
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 07, 2019 at 04:57:15PM +0200, Vlastimil Babka wrote:
> On 10/5/19 12:11 AM, Roman Gushchin wrote:
> >
> > One possible approach to this problem is to switch inodes associated
> > with dying wbs to the root wb. Switching is a best effort operation
> > which can fail silently, so unfortunately we can't run once over a
> > list of associated inodes (even if we'd have such a list). So we
> > really have to scan all inodes.
> >=20
> > In the proposed patch I schedule a work on each memory cgroup
> > deletion, which is probably too often. Alternatively, we can do it
> > periodically under some conditions (e.g. the number of dying memory
> > cgroups is larger than X). So it's basically a gc run.
> >=20
> > I wonder if there are any better ideas?
>=20
> I don't know this area, so this will be likely easily shown impossible,
> but perhaps it's useful to do that explicitly.
>=20
> What if instead of reparenting each inode, we "reparent" the wb?

It seems to be an arguable idea, at least at the offlining moment.
Dirty memory left after a cgroup should be written back using
corresponding limits, and reparenting can easily break them.

Also, it's not clear to me, how to reparent dirty stats?

> But I see it's not a small object either. Could we then add some bias
> for inode switching conditions so that anyone else touching the inode
> from dead wb would get it immediately?

You mean touching for writing? That's doable, but doesn't solve the case
when there are only readers. And the case is quite common.

> And what would happen if we reused the reparented wb's for newly created
> cgroups? Would it "punish" them for the old inodes?
>=20

No idea, to be honest.

Thank you!