Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5111738ybp; Mon, 7 Oct 2019 20:20:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZxEQtnMp0Mt5LfJW1NCNNv48d0HcriwzBFgZQ0nIzE9H6tlM8AcUZrQUrMnIA/J42IKvJ X-Received: by 2002:a50:f152:: with SMTP id z18mr31281288edl.141.1570504859729; Mon, 07 Oct 2019 20:20:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570504859; cv=none; d=google.com; s=arc-20160816; b=gcUSxGPS2gXoy8ftH/XUtbjBYybyOgswq45kRV6zuA0+nK7ZbK8mWf4sY0ta1IvPar YUawWwNhuU5RgvFvWr1PZlzjz/vhMA7fAAYv113dbMJsTYlzuoaPImB1eowmvi53sv4t LYNijFKbto+r7GbnF1Fu4qf0gvuflZIzBnzEEKRuzl5BKyb0xdR7W2F+k+YteC/25aAJ R8TNB44ikVytZaH8LmQ24STMfn1Nuz2+zD3iSWHYM/zINE5Gl+dgcSadAhVq0mU16Dyo aNPeOdg5cD1/HvhTIpYww6IWEI/HxA/FbYRX++utIjvM+aKrYLHb8fA0cLMPwnWLQO8i ohvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=sBhKqNlCBDPkftr27P/1IjQptr0YXTqXNyc4wrCVHCs=; b=0sLfNE04jnN/RpFqc3Lb8GBQ56oU018GKBJf7R6XlAVnEzzZ5JC5phHpSbfK58tm46 K3gM6iBwAZvAJHU+C+DOpR2XTkjdjz3GiZfT0xHutaON0YLLYP7Lfl8OoMIdrDEJPRuP 2hkCNLLAAPaCLHULk2SmpNjYvfHmR70HP1jumZIVsaU7tsyT9KiLSNsnGRSL7bXHBniH kPpphxHdZa0OeupN2zNKsjmaY/amUe6iWcZtYnnIhVpdD4nPdyzUqJLcUlSSDj4gkwbX KULfuqXlJq20I/VJCQJ3zfbiTnhHETeL7E0K85wXWYv4PDsyBJaQb4v9hy37WiHizrDL k1gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=KwXd9fN7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2si9300695edt.408.2019.10.07.20.20.36; Mon, 07 Oct 2019 20:20:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=KwXd9fN7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729894AbfJHDSA (ORCPT + 99 others); Mon, 7 Oct 2019 23:18:00 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43404 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729868AbfJHDSA (ORCPT ); Mon, 7 Oct 2019 23:18:00 -0400 Received: by mail-pg1-f195.google.com with SMTP id i32so2145011pgl.10 for ; Mon, 07 Oct 2019 20:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=sBhKqNlCBDPkftr27P/1IjQptr0YXTqXNyc4wrCVHCs=; b=KwXd9fN7sM6S4HqcH6F8Fq+m+XYPerHKPiNSvQR2F1QiQtVIQE+nIlWn6Q8PpHhho3 iKAX+N6dedzbUCk0rOTijgDmFBbGQtrLv6csEuCeXIQjzImHbAUoIN37aOc5gpctJxOF 5Yb3hQt9N8P0fH/XEiIrrHtWqRrpULXdYkgYDxM/+CbOlnP5yhRkxO94ecv+W1Wr0Nm1 YO7fIF7mJQ265INnz8hwnN3iqExG1g6CoqkHHHDDpjbhSQqpUSnIyQcF05FOL71TosBQ prc/hZax9kJYb46OUODcifTFk/n2fFG+Isyhs4q2PZUng5eh+rzPDInIdxsDVxA18Ohu T7/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sBhKqNlCBDPkftr27P/1IjQptr0YXTqXNyc4wrCVHCs=; b=h8X5auHWRqCOrlYd1LEEBc/FfR+3njZ1+b9KCX+QbC2e49kMm1/NRsqJ3Qj2iP40wi IerBrfNr33ColICGCuLCxIEmTDefS69ycfyLjbjh+FyHAxKaS0D3gUiJn0H9AlCB5vJk CSOouAsbEdPhe+OqTQkLf5+hLDP2vp1hYVrfkW+K8v/A1mRIOTns1qBk0ipJrpMjxFS6 L4t4aDtOS0ZUlndSqMTsfwA+c/xlBD9b7pRxJUgmAPshTLP9X+z+ABWvD1fij5VnDFII 8YeUJQ7lbhKjzqC5pe/xiAooWNemEq71W3oPKVLt4GcJSUaeQhh8pi/qf4YzaEFwzZMN Hptw== X-Gm-Message-State: APjAAAXfLDKVvOc2jxf/zjywy1yQecWp7NePRaEMtyX1lWBkKmQGqfqf 4yO0ALPPGGwQSMkXy7uAptBTxpqlMbZ2lg== X-Received: by 2002:a63:dc4c:: with SMTP id f12mr1766256pgj.29.1570504677476; Mon, 07 Oct 2019 20:17:57 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.79]) by smtp.gmail.com with ESMTPSA id 64sm19333739pfx.31.2019.10.07.20.17.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 20:17:56 -0700 (PDT) Subject: Re: [PATCH] blk-stat: Optimise blk_stat_add() To: "Pavel Begunkov (Silence)" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <39dd33cc6f0264b2ec2f79f1dfe21466c2180851.1570482929.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: Date: Mon, 7 Oct 2019 21:17:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <39dd33cc6f0264b2ec2f79f1dfe21466c2180851.1570482929.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/19 3:16 PM, Pavel Begunkov (Silence) wrote: > From: Pavel Begunkov > > blk_stat_add() calls {get,put}_cpu_ptr() in a loop, which entails > overhead of disabling/enabling preemption. The loop is under RCU > (i.e.short) anyway, so do get_cpu() in advance. Looks good, applied for 5.5. -- Jens Axboe