Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5273172ybp; Mon, 7 Oct 2019 23:40:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqywkc+YnhP7+UoF3Wm+jwkRMoN2LX1NhV5pxI3vrPDWmluYdElxoIigD3JetKZqDyvViGiu X-Received: by 2002:a17:906:4a17:: with SMTP id w23mr18805193eju.324.1570516822270; Mon, 07 Oct 2019 23:40:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570516822; cv=none; d=google.com; s=arc-20160816; b=Z7JQ1467X9JU8HK4+fZMTMlnAruw/686Gcepaxyol1KfHS2Gzf9haQC1hMGmxCJTGU izuWNsUw3JCAqgEHv1SYklWOjcJA5j6LLA3TaXCd1ZnnMrNx9PqhdklvOCUCGY/84dyJ exApwekkaQtszKBIC9pOsdJENV5/QnmXdihamuKg129DNIiYIyvRbj4Q9NuBhsg6qMaL vAIRUf3u1Tx81yLfVgamo4T5wgrt4uCnehpZubwbWIAXxYbD+RU+wLItGzGwZPC7Htlg Dnq+8lQmSlAXvd7xK4pJ5uMzQuL+R6Ml9n3LTMHAPb2UhVICutseFnHSz254ebZ1FDuL s5yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=FelKE+td56f2BxYmeawf1JtI6yDKNIr/fv4F4QyQIAs=; b=I4Zn67jmiTFH5yzStxiFmMjk7mQA8IhnPFXSJj40kBoDT26o3hKGfoq54eYImSt/x7 WDvg2BrLxOf3V3Oy5WOGywH2x/BVFOwcxMiV3ynWaiBCPvUU8gb96ur8ldOwqGKSiMgj GEhfD5gi+OHxe7d7mSKk5K4FO5mzn8tWwQCb22nfWS4XPr0d5pe2626p0fFjP9uh/7xF WA99xmNTv0ZoKjJaWmpCrpY6vv0IUlI0OmM5iJwHpPegN6IM3BKyS8324Z/LIsijdG8C b37+wkIb5OkZ+J5YhSQhTU8u7EIN6GVHyEcpHuFfQh5KHG5JvFFKidtGvRR+gasAKC+2 vcxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6si8531242ejx.293.2019.10.07.23.39.59; Mon, 07 Oct 2019 23:40:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730132AbfJHGjk (ORCPT + 99 others); Tue, 8 Oct 2019 02:39:40 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3217 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729937AbfJHGjj (ORCPT ); Tue, 8 Oct 2019 02:39:39 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 1BA09D3084733FCB0373; Tue, 8 Oct 2019 14:39:37 +0800 (CST) Received: from [127.0.0.1] (10.133.217.137) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Tue, 8 Oct 2019 14:39:33 +0800 Subject: Re: [PATCH 00/32] Kill pr_warning in the whole linux code To: Petr Mladek , Linus Torvalds CC: Arnd Bergmann , Andy Whitcroft , "David S. Miller" , Sergey Senozhatsky , Peter Zijlstra , "Daniel Borkmann" , AlexeiStarovoitov , "Andrew Morton" , GregKroah-Hartman , Joe Perches , "Arnaldo Carvalho de Melo" , Ingo Molnar , References: <20190920062544.180997-1-wangkefeng.wang@huawei.com> <20191002085554.ddvx6yx6nx7tdeey@pathway.suse.cz> From: Kefeng Wang Message-ID: Date: Tue, 8 Oct 2019 14:39:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20191002085554.ddvx6yx6nx7tdeey@pathway.suse.cz> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.217.137] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On 2019/10/2 16:55, Petr Mladek wrote: > Linus, > > On Fri 2019-09-20 14:25:12, Kefeng Wang wrote: >> There are pr_warning and pr_warng to show WARNING level message, >> most of the code using pr_warn, number based on next-20190919, >> >> pr_warn: 5189 pr_warning: 546 (tools: 398, others: 148) > > The ratio is 10:1 in favor of pr_warn(). It would make sense > to remove the pr_warning(). > > Would you accept pull request with these 32 simple patches > for rc2, please? > > Alternative is to run a simple sed. But it is not trivial > to fix indentation of the related lines. Kindly ping, should I respin patches with comments fixed? Is the patchset acceptable, hope to be clear that what to do next :) Thanks > > Best Regards, > Petr > > . >