Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5278466ybp; Mon, 7 Oct 2019 23:47:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqzvchy7rWJSadT+EoXlFhV0n/s/1jjev6EwtUEHGh4yVhmynrltM/Tz8P/09bAn4uZtmhcN X-Received: by 2002:a50:cd1a:: with SMTP id z26mr31866702edi.75.1570517240591; Mon, 07 Oct 2019 23:47:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570517240; cv=none; d=google.com; s=arc-20160816; b=YeQ2iP/OgQerFVdI6uNEs4YXdBVkjn0w3kI0WDrsunLDAjS/2Il9ZRyV1SjxSwEhKj JiDT4PghSD7f3W6TfF7Tkmm+DXsOvCw9wejUUS8S2lu6QO6LjZe+p/gJpy56MtwwV3tN CwwFNezdo9i0ugX9U332BKSjV3Xn73aPbkxdOvLAp0BLhF2jUSYbVwOQx2rKkBo1tZq8 u/yKypIxH2HBBbw7DyyfCaRMv5psgM30N3el+j9vH7mSw94lAnuJYLlOJzojzJBhjzhZ BFbpQiE7UW5RAVZD/SDxl0jwsIsFEkJ7rZeRiNepFp9eSVGL+pgYnsbct/TXetFYNKE5 Rt9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=nV1m2QFCmjxZ65BsrYM+g61Iop05FqQhe1MRAr3hPnQ=; b=NBkdoH9r3J7m2yLBRIB81eTMifaLblxg4YMl5jsiC6q7I83+Sf4HXPe2gkXtvLL7c6 6A+suH3b+NJ7c2AbOgt1Px5VtwgfwEu0WwkbPruJVnq1iqLMBz+xCQAQFnWNSAG1cEFA BG7O2qY8iQhTBo88HXwezRRCe3bMoNUA+MIUlDTjhMVxhYjvi54/B6TWV+PObzwiei9s cCGQjtr29keA4golJwJF6tHtYjg4zKHYCBGieAw/P7rqjdg8/TGO+V7vVk+LsPA1BKRO +rxYgd9vWp77VhxJQ3YzIuuAUS05lD/90GtqIar1sTfmLeyNpZ1Ct6H0HRY1TyE7dL8x ZUJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay11si7234328edb.215.2019.10.07.23.46.57; Mon, 07 Oct 2019 23:47:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730134AbfJHGoY convert rfc822-to-8bit (ORCPT + 99 others); Tue, 8 Oct 2019 02:44:24 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:2058 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729693AbfJHGoY (ORCPT ); Tue, 8 Oct 2019 02:44:24 -0400 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id F2842D9559FCC1541F18; Tue, 8 Oct 2019 14:44:18 +0800 (CST) Received: from dggeme716-chm.china.huawei.com (10.1.199.112) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 8 Oct 2019 14:44:18 +0800 Received: from dggeme763-chm.china.huawei.com (10.3.19.109) by dggeme716-chm.china.huawei.com (10.1.199.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 8 Oct 2019 14:44:18 +0800 Received: from dggeme763-chm.china.huawei.com ([10.6.66.36]) by dggeme763-chm.china.huawei.com ([10.6.66.36]) with mapi id 15.01.1713.004; Tue, 8 Oct 2019 14:44:18 +0800 From: linmiaohe To: "adobriyan@gmail.com" , "tglx@linutronix.de" , "akpm@linux-foundation.org" , "dhowells@redhat.com" , "cyphar@cyphar.com" , "christian@brauner.io" , "aubrey.li@linux.intel.com" CC: Mingfangsen , linmiaohe , "mm-commits@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH] proc:fix confusing macro arg name Thread-Topic: [PATCH] proc:fix confusing macro arg name Thread-Index: AdV9gOdeS5V1IJ1hQmaaEj6tyX7o5A== Date: Tue, 8 Oct 2019 06:44:18 +0000 Message-ID: <165631b964b644dfa933653def533e41@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.189.20] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add suitable additional cc's as Andrew Morton suggested. Get cc list from get_maintainer script: [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch Alexey Dobriyan (reviewer:PROC FILESYSTEM) linux-kernel@vger.kernel.org (open list:PROC FILESYSTEM) linux-fsdevel@vger.kernel.org (open list:PROC FILESYSTEM) ------------------------------------------------------ From: Miaohe Lin Subject: fix confusing macro arg name state_size and ops are in the wrong position, fix it. Signed-off-by: Miaohe Lin Reviewed-by: Andrew Morton Cc: Alexey Dobriyan Signed-off-by: Andrew Morton --- include/linux/proc_fs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644 --- a/include/linux/proc_fs.h +++ b/include/linux/proc_fs.h @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode, struct proc_dir_entry *parent, const struct seq_operations *ops, unsigned int state_size, void *data); -#define proc_create_net(name, mode, parent, state_size, ops) \ - proc_create_net_data(name, mode, parent, state_size, ops, NULL) +#define proc_create_net(name, mode, parent, ops, state_size) \ + proc_create_net_data(name, mode, parent, ops, state_size, NULL) struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode, struct proc_dir_entry *parent, int (*show)(struct seq_file *, void *), void *data); -- 2.21.GIT