Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Oct 2019 18:27:37 +1100
From:   Aleksa Sarai <cyphar@cyphar.com>
To:     linmiaohe <linmiaohe@huawei.com>
Cc:     "adobriyan@gmail.com" <adobriyan@gmail.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        "christian@brauner.io" <christian@brauner.io>,
        "aubrey.li@linux.intel.com" <aubrey.li@linux.intel.com>,
        Mingfangsen <mingfangsen@huawei.com>,
        "mm-commits@vger.kernel.org" <mm-commits@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] proc:fix confusing macro arg name
Message-ID: <20191008072737.hkt53lf4hdx6bola@yavin.dot.cyphar.com>
References: <165631b964b644dfa933653def533e41@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xvn3q4ilxem2qqbc"
Content-Disposition: inline
In-Reply-To: <165631b964b644dfa933653def533e41@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--xvn3q4ilxem2qqbc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2019-10-08, linmiaohe <linmiaohe@huawei.com> wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-=
macro-arg-name.patch=20
> Alexey Dobriyan <adobriyan@gmail.com> (reviewer:PROC FILESYSTEM)
> linux-kernel@vger.kernel.org (open list:PROC FILESYSTEM)
> linux-fsdevel@vger.kernel.org (open list:PROC FILESYSTEM)
>=20
> ------------------------------------------------------
> From: Miaohe Lin <linmiaohe@huawei.com>
> Subject: fix confusing macro arg name
>=20
> state_size and ops are in the wrong position, fix it.
>=20
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Looks reasonable.

Acked-by: Aleksa Sarai <cyphar@cyphar.com>

> ---
>=20
>  include/linux/proc_fs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705=
aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct pro=
c_dir_entry *);  struct proc_dir_entry *proc_create_net_data(const char *na=
me, umode_t mode,
>  		struct proc_dir_entry *parent, const struct seq_operations *ops,
>  		unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> -	proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> +	proc_create_net_data(name, mode, parent, ops, state_size, NULL)
>  struct proc_dir_entry *proc_create_net_single(const char *name, umode_t =
mode,
>  		struct proc_dir_entry *parent,
>  		int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
>=20


--=20
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

--xvn3q4ilxem2qqbc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXZw6ZgAKCRCdlLljIbnQ
EiEGAQDG9zRJQF5jUEsy8iMlB83kVXNRjV/eaNv4FlZQxbdtbQD+JM6uYaDbPpOs
EWiAKUr9k7mf2zBxaLqEzL8/eqYJxQA=
=QSng
-----END PGP SIGNATURE-----

--xvn3q4ilxem2qqbc--