Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jbergsagel@ti.com" <jbergsagel@ti.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
        Suresh Punnoose <sureshp@cadence.com>,
        Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.
Thread-Topic: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.
Thread-Index: AQHVfNoJ++ECtmBATUSOETiOVkdrz6dQUUWAgAARBwCAAAhcsA==
Date:   Tue, 8 Oct 2019 08:44:42 +0000
Message-ID: <VI1PR04MB53276319AB49C454A7A0318B8B9A0@VI1PR04MB5327.eurprd04.prod.outlook.com>
References: <1570430355-26118-1-git-send-email-pawell@cadence.com>
 <20191008065619.GE5670@b29397-desktop>
 <BN7PR07MB47056F9852550657E9651DD7DD9A0@BN7PR07MB4705.namprd07.prod.outlook.com>
In-Reply-To: <BN7PR07MB47056F9852550657E9651DD7DD9A0@BN7PR07MB4705.namprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 005f7745-b84b-4559-2f87-08d74bcbc3c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 08:44:43.0074
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mIGPELhPvseSBKSNyvnJMEmXkzYTs6yNHin5O9y27nqBSLUwgpJ8eHZRweevVSPVk1K+7oG5ZgDoDCf77bDYkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7101
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> >> Endpoint can defer transition to Halted state if endpoint has pending
> >> requests.
> >
> >The implementation of halt handling is a little complicated, you may
> >consider return -EAGAIN for functional stall through usb_ep_set_halt
> >from function driver if the requests are pending, it doesn't need to
> >defer such kinds of functional stall.
>=20
> Yes, I remember your suggestion regarding using EAGAIN, but f_mass_storag=
e
> Driver simple check the status and try to stall endpoint again after 100 =
ms.
>=20
> What if Command Verifier ask for endpoint status before this time, or if =
the transfer
> will not be finished on time ? Then the CV test may fail.
>=20
> So solution from this patch should be more certain.
>=20

Your description is reasonable, since I have not met this issue, I would li=
ke
to know more about it:=20
It occurs at CV9 or MSC test? For CV9 test, it may not try to stall non-ep0=
.
Which test case was failed?

Peter

> >
> >Peter
> >> Patch add additional condition that allows to return correct endpoint
> >> status during Get Endpoint Status request even if the halting
> >> endpoint is in progress.
> >>
> >> Reported-by: Rahul Kumar <kurahul@cadence.com>
> >> Signed-off-by: Rahul Kumar <kurahul@cadence.com>
> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> >> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> >> ---
> >>  drivers/usb/cdns3/ep0.c | 10 ++++++++--
> >>  1 file changed, 8 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c index
> >> 44f652e8b5a2..10ae03430f34 100644
> >> --- a/drivers/usb/cdns3/ep0.c
> >> +++ b/drivers/usb/cdns3/ep0.c
> >> @@ -234,9 +234,11 @@ static int cdns3_req_ep0_set_address(struct
> >> cdns3_device *priv_dev,  static int cdns3_req_ep0_get_status(struct
> cdns3_device *priv_dev,
> >>  				    struct usb_ctrlrequest *ctrl)  {
> >> +	struct cdns3_endpoint *priv_ep;
> >>  	__le16 *response_pkt;
> >>  	u16 usb_status =3D 0;
> >>  	u32 recip;
> >> +	u8 index;
> >>
> >>  	recip =3D ctrl->bRequestType & USB_RECIP_MASK;
> >>
> >> @@ -262,9 +264,13 @@ static int cdns3_req_ep0_get_status(struct
> cdns3_device *priv_dev,
> >>  	case USB_RECIP_INTERFACE:
> >>  		return cdns3_ep0_delegate_req(priv_dev, ctrl);
> >>  	case USB_RECIP_ENDPOINT:
> >> -		/* check if endpoint is stalled */
> >> +		index =3D cdns3_ep_addr_to_index(ctrl->wIndex);
> >> +		priv_ep =3D priv_dev->eps[index];
> >> +
> >> +		/* check if endpoint is stalled or stall is pending */
> >>  		cdns3_select_ep(priv_dev, ctrl->wIndex);
> >> -		if (EP_STS_STALL(readl(&priv_dev->regs->ep_sts)))
> >> +		if (EP_STS_STALL(readl(&priv_dev->regs->ep_sts)) ||
> >> +		    (priv_ep->flags & EP_STALL_PENDING))
> >>  			usb_status =3D  BIT(USB_ENDPOINT_HALT);
> >>  		break;
> >>  	default:
> >> --
> >> 2.17.1
> >>
> >
> >--
> >
> >Thanks,
> >Peter Chen
>=20
> Regards,
> Pawel