Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5485313ybp; Tue, 8 Oct 2019 03:41:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGa4gabuhmKOLvNZ7svjtPJyri+LOa74m8LiiGS2APnKZMwPFxtptU+UiEeUMx4JTgn1z1 X-Received: by 2002:a50:ab84:: with SMTP id u4mr33446078edc.13.1570531313427; Tue, 08 Oct 2019 03:41:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570531313; cv=none; d=google.com; s=arc-20160816; b=aDznP9WLA4FvoOjC4XJmJbK4xcUdsjsCdtFBSg5v5UissQwpZR2IUBaqjYZk9mjPWI uIGkuipCCNup4vEyO5VANix/sKdlkY/Bc0eGWb8Z0u8VjTeGl9qzQr1k5yK8h9ZysJzw eQWGXlgfw4OWyojtpnv28LlqhdTOSpE5nhpl6MTZIMDHZZDPevfnX7iWJE15IvPCD6Go c8ZESBANT2sBVW1oksLYKh2Z9sBxJppZHOlMJib2PDq/e51je9DYktjLvryS3fgFce9W OvDhosHjbOdU8J12Ntl1d7B62ZbkIiyx75LHyqdZdexYWXcSxb03pqS7P5bTD2d9OjIA G1NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=bbEk7+RZyoWJDAyxR0TJcDnXGQ+7Xa4/5O9nDnOUnxo=; b=vDT9CkJnzfV+/e8WyFDz2pEFaQPMs6IACaCZ6u3SFP1fbgp0v06U/XIP9fORK3hpeo sqxG0eeTNk6HnCS234Cl5yuHyRcHruJPHPMJol2fdWJ0nONv0JRMSMqQZ027H9aq+9So 8x811S1AA3XaJ9xRuWVWXmq1P3/8bB79t0Kdese+Z+66p6w62y+TEX/wEBRh70JGAxn4 tPsloU2hz21wo07oxzWaUrg8lX4Ybz2/Sar+fAlGpYS5aP7UYiNUja7NzV010S6G87/u +szZ830t1hhglX5ZJqBLbcMSI9QobPCWCxHGkt5me9ydG23ALhJHK9m2AjdJ2sjJA40c QbBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g50si10291130edb.47.2019.10.08.03.41.30; Tue, 08 Oct 2019 03:41:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730475AbfJHKjO (ORCPT + 99 others); Tue, 8 Oct 2019 06:39:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:41300 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730256AbfJHKjK (ORCPT ); Tue, 8 Oct 2019 06:39:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EB0CFAEAF; Tue, 8 Oct 2019 10:39:08 +0000 (UTC) Date: Tue, 8 Oct 2019 12:39:07 +0200 From: Michal Hocko To: Qian Cai Cc: Petr Mladek , akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org, peterz@infradead.org, linux-mm@kvack.org, john.ogness@linutronix.de, david@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk() Message-ID: <20191008103907.GE6681@dhcp22.suse.cz> References: <20191008084031.GC6681@dhcp22.suse.cz> <298970BD-529E-4095-8D87-61470ADBDD32@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <298970BD-529E-4095-8D87-61470ADBDD32@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 08-10-19 06:04:32, Qian Cai wrote: > > > > On Oct 8, 2019, at 4:40 AM, Michal Hocko wrote: > > > > Does this tip point to a real deadlock or merely a class of lockdep > > false dependencies? > > I lean towards it is a real deadlock given how trivial to generate those lock orders everywhere. Have you actually triggered any real deadlock? With a zone->lock in place it would be pretty clear with hard lockups detected. -- Michal Hocko SUSE Labs