Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5574287ybp; Tue, 8 Oct 2019 05:12:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGUqTM6Fkh+xB121RdNVAYTINvPPEnx7dHIM79uZjSORylXiu/uCBkNeVVz1Gg2Ugzgk1D X-Received: by 2002:aa7:dad9:: with SMTP id x25mr33806334eds.7.1570536770956; Tue, 08 Oct 2019 05:12:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570536770; cv=none; d=google.com; s=arc-20160816; b=oyil1r4+U5TgADvHI2g4zosfXU5SXVZp6suwlObx1/A53QYo36tSIqI7N2jzhUu4q0 oPvI2m2IWlpEMj0B7d+jSZiIpzo5HUmTk5S1MvotfMeCGl0LboS/bTE1dXHo2vuOOTP5 g9+a2IpcpgMWiG1bVpn/0KX5zoG4ZZS/06pjNI2W9er+dYOYy93yvHWo92fVgyQEbfeK lD5siCu9e6db5WNFRAVo4aTOGXAhVoKJNWXr4A8coj3CE4YNfNqp3FGlUHTYNglSlS/I wveCMC3bDxgTrDLCnR1oDd4nO8S0+eo+iqasHkxo8XqLkZjv9kvZMVbkFIfyEx2rmLMo OG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=bMfWy0Dl2AfSzPzNkq3miOZZqq5TcHskfkYBdZCpQs4=; b=ya94s2Um8bAx/4krjX57BAfGKDS/3OHHu6Ij3XKHy85AyNNjLBu13uv+2i459sJ3CU 9oU4U7U6dyIImekO1jLgrXhUl+JYQYRt0j4u4JGhaHX2iwAJGgpO5y8ILn+ZNhG2wDPi nlKzcwQht8vS1Qiaj46X2/cxZ7MsUcduiUhik/J1nqEB8ob5VLUakGYFbEDqzaZb2B8M a/2U9TmWbm7MOQDDIdt1cHYlMYG+LWAoSk4/9rWpOCsACi0bnAtV4mBbCMVeJdomXcfR kW/q7SbhFpcwEs4hv0qf7znO7ek7yJmCNLV8zmvX7panzhNDQNVrwHPhRTSCtC2AYPCn GpMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si8462913eje.176.2019.10.08.05.12.27; Tue, 08 Oct 2019 05:12:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731205AbfJHMLh (ORCPT + 99 others); Tue, 8 Oct 2019 08:11:37 -0400 Received: from inva021.nxp.com ([92.121.34.21]:40896 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731162AbfJHMLd (ORCPT ); Tue, 8 Oct 2019 08:11:33 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 1EDAC200301; Tue, 8 Oct 2019 14:11:31 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 129E22002DE; Tue, 8 Oct 2019 14:11:31 +0200 (CEST) Received: from fsr-fed2164-101.ea.freescale.net (fsr-fed2164-101.ea.freescale.net [10.171.82.91]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id BB8C8205DB; Tue, 8 Oct 2019 14:11:30 +0200 (CEST) From: Madalin Bucur To: davem@davemloft.net, netdev@vger.kernel.org Cc: roy.pledge@nxp.com, laurentiu.tudor@nxp.com, linux-kernel@vger.kernel.org, Madalin Bucur Subject: [PATCH 17/20] dpaa_eth: remove netdev_err() for user errors Date: Tue, 8 Oct 2019 15:10:38 +0300 Message-Id: <1570536641-25104-18-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1570536641-25104-1-git-send-email-madalin.bucur@nxp.com> References: <1570536641-25104-1-git-send-email-madalin.bucur@nxp.com> Reply-to: madalin.bucur@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org User reports that an application making an (incorrect) call to restart AN on a fixed link DPAA interface triggers an error in the kernel log while the returned EINVAL should be enough. Reported-by: Joakim Tjernlund Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c index 1c689e11c61f..126c0f1d8442 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -81,7 +81,6 @@ static int dpaa_get_link_ksettings(struct net_device *net_dev, struct ethtool_link_ksettings *cmd) { if (!net_dev->phydev) { - netdev_dbg(net_dev, "phy device not initialized\n"); return 0; } @@ -96,7 +95,6 @@ static int dpaa_set_link_ksettings(struct net_device *net_dev, int err; if (!net_dev->phydev) { - netdev_err(net_dev, "phy device not initialized\n"); return -ENODEV; } @@ -143,7 +141,6 @@ static int dpaa_nway_reset(struct net_device *net_dev) int err; if (!net_dev->phydev) { - netdev_err(net_dev, "phy device not initialized\n"); return -ENODEV; } @@ -168,7 +165,6 @@ static void dpaa_get_pauseparam(struct net_device *net_dev, mac_dev = priv->mac_dev; if (!net_dev->phydev) { - netdev_err(net_dev, "phy device not initialized\n"); return; } -- 2.1.0