Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5578613ybp; Tue, 8 Oct 2019 05:16:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMSIayHi8TN6dykoIfPNMrloxUQD9/7g6otVeN+0HejJhujDB2ZEbcYmPK3uUlXDWoIwMq X-Received: by 2002:a17:906:bcd9:: with SMTP id lw25mr20684277ejb.315.1570537004356; Tue, 08 Oct 2019 05:16:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570537004; cv=none; d=google.com; s=arc-20160816; b=pKGxkddqqQUG+LiCiJlLFyiA4fJoxGHFscz2GFiK0bfcaykkG6LAfgX+7wbha7B7rd IoYn6QuviT26FXYkYdObTLTxUJZyu8nMu9rmOgica5gOKZi/LD140BpcKS18H5fIW2x9 sun7wBj1sZibPfNJ+kFLeTxk6RsDjUygc04IntsrPXad7zCXPhwP2fdIO/w6ESfUjM3T i4k7NwZpEkHJVBehsqC7mqYVLPAIxQAzBGwqT3mfpH5b1QWD0hM3q7Aq9dncnMczmUTv 7ziUz+NHjH6thIkZWEx/PUMaXuefc1TAONxNxUlpsk7mJHd63ED5Hk+401mmfRowkpSw 1LMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=ODbPVLuOi4J8gkb0fUskq7QdEt9hhebZtna0E4fEnmU=; b=VMYg0QQ8vajMlitxyD3Wv/cIvQ5hL0rUh7jGm/Hp6yjF9STpzf7nRWZzJJuD3uHLo6 0ispI1zx42lDYLYO6wDQrFSPxxz+N2hM+pxgxrt/Rd0YWjSBw2wq69BR9VFc4qCFSSQ7 dQ1A4fgtADlQhyl4V3uKnrA0dyKPraQ2HXKK7FG2LOK968ICHC6yXxTfOAK0ElRSV319 +19jDt6rG332VoY9UQu1tt+M5/RHZ9lvJzOFjwQ6KOjM0xAuB3uL4efS+CoGu1g6OtRG VWM9p2rboquJK6u3nQrqDgNAiKMWn7n3hpaAnUoIMAVeTZA9K1Y0sBPirYVT6wRRXXn9 m05Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci22si8784943ejb.162.2019.10.08.05.16.20; Tue, 08 Oct 2019 05:16:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730884AbfJHMK4 (ORCPT + 99 others); Tue, 8 Oct 2019 08:10:56 -0400 Received: from inva021.nxp.com ([92.121.34.21]:40412 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730873AbfJHMKy (ORCPT ); Tue, 8 Oct 2019 08:10:54 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id B46F8200181; Tue, 8 Oct 2019 14:10:52 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id A845C2002CF; Tue, 8 Oct 2019 14:10:52 +0200 (CEST) Received: from fsr-fed2164-101.ea.freescale.net (fsr-fed2164-101.ea.freescale.net [10.171.82.91]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 5F9D52060B; Tue, 8 Oct 2019 14:10:52 +0200 (CEST) From: Madalin Bucur To: davem@davemloft.net, netdev@vger.kernel.org Cc: roy.pledge@nxp.com, laurentiu.tudor@nxp.com, linux-kernel@vger.kernel.org, Madalin Bucur Subject: [PATCH 01/20] fsl/fman: don't touch liodn base regs reserved on non-PAMU SoCs Date: Tue, 8 Oct 2019 15:10:22 +0300 Message-Id: <1570536641-25104-2-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1570536641-25104-1-git-send-email-madalin.bucur@nxp.com> References: <1570536641-25104-1-git-send-email-madalin.bucur@nxp.com> Reply-to: madalin.bucur@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor The liodn base registers are specific to PAMU based NXP systems and are reserved on SMMU based ones. Don't access them unless PAMU is compiled in. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index 210749bf1eac..934111def0be 100644 --- a/drivers/net/ethernet/freescale/fman/fman.c +++ b/drivers/net/ethernet/freescale/fman/fman.c @@ -634,6 +634,9 @@ static void set_port_liodn(struct fman *fman, u8 port_id, { u32 tmp; + iowrite32be(liodn_ofst, &fman->bmi_regs->fmbm_spliodn[port_id - 1]); + if (!IS_ENABLED(CONFIG_FSL_PAMU)) + return; /* set LIODN base for this port */ tmp = ioread32be(&fman->dma_regs->fmdmplr[port_id / 2]); if (port_id % 2) { @@ -644,7 +647,6 @@ static void set_port_liodn(struct fman *fman, u8 port_id, tmp |= liodn_base << DMA_LIODN_SHIFT; } iowrite32be(tmp, &fman->dma_regs->fmdmplr[port_id / 2]); - iowrite32be(liodn_ofst, &fman->bmi_regs->fmbm_spliodn[port_id - 1]); } static void enable_rams_ecc(struct fman_fpm_regs __iomem *fpm_rg) @@ -1942,6 +1944,8 @@ static int fman_init(struct fman *fman) fman->liodn_offset[i] = ioread32be(&fman->bmi_regs->fmbm_spliodn[i - 1]); + if (!IS_ENABLED(CONFIG_FSL_PAMU)) + continue; liodn_base = ioread32be(&fman->dma_regs->fmdmplr[i / 2]); if (i % 2) { /* FMDM_PLR LSB holds LIODN base for odd ports */ -- 2.1.0