Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5604216ybp; Tue, 8 Oct 2019 05:41:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwj5OwW9C+AC2DTgcfeE/E+s9lSRKLsSXi4shyxmnZTj67ruhjyea69wvVHkezdhth0yL48 X-Received: by 2002:a17:906:4a06:: with SMTP id w6mr27860442eju.214.1570538515454; Tue, 08 Oct 2019 05:41:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570538515; cv=none; d=google.com; s=arc-20160816; b=0PY+IdoXhKaZ0aunMWVw9WQoScMuY7HM9sbHJBihBptrnjsqllbp7pYbrFpFSrCY1X yGEv8Lp0jDNN6vK1c4KbCNXyOEc3dspdG2oyDEA9x8pbFB0vtbfYsQSyOGedIUh/xk+w BP9NDj2QUMFyGgds/ocPLNQJPjAWAb/D02MVq6s6jYJ5OI/Nf5Q5z2yGINY7qz1MD1bl 876bu7vXbNfcccsK5urcgpZvXPwqwpdrzXjV6/weukkaRY/L+SAubjKUyEY1R8aDmmc2 8/dQo/q6dawkj3n3t8HxpNCHrsZLxvv9xizt7IRvy15K8nxcud63Rn5peWln66CQc/Oy /nRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ocRMVi692l2LPetRyUP4sQ3IVeF2pvECNxieL0pLtfI=; b=I0BG3b9FIbpI/t0ymuDEPzARFLt0puR73B4ndS/FV1VmDos6KE/1zpbWSSRFQedg5m aq/MhKzRjT5FOkFuipJ7ukslyfvWZyeWS91Kotu/ZvjrsQyw5xJvnD5YdqNJvUaeONcf zqBv2oF8hJtB5g4Rpvzn3m9gkbT8vwo3lFJmGEbWipqkKQWRhME9S1C8Wgs8WoBNzoCZ 8f+RYEUSabTOrs4TuTvJJMbGfIbRrMuzeJmQR9JBYsRJTEjB4h6aNu7l/Zo/7hWUUko3 sK4derScqGMbSTuIjZ7pZWgiidGZsP5sdxoZ0XpYzPTRiSGiaHS+PQmg633JTeZa2NNp UFBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Fj0cjOYf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k16si8842130ejo.7.2019.10.08.05.41.32; Tue, 08 Oct 2019 05:41:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Fj0cjOYf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730972AbfJHMi2 (ORCPT + 99 others); Tue, 8 Oct 2019 08:38:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:37230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730705AbfJHMi2 (ORCPT ); Tue, 8 Oct 2019 08:38:28 -0400 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27E3F20815; Tue, 8 Oct 2019 12:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570538307; bh=0172FbZMwE+uHkpHQaDTjmrpy7r6UVMZViKRxp2jAkE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Fj0cjOYfJqhfG7IwXrmsg43ZvERQ73aD0HiD62uK8K0QAnuFy4VbETrnvYSymrBqN xM7+aR53XRnXLF/IMVEBQZral9XGk3sgp1dp0oYVgvM71fmByrgK0ow2kcUo6seEJK WtzTvf6j2ztu57+zCR9T41ITyxFFnOHtYtMF77Dg= Received: by mail-qt1-f178.google.com with SMTP id 3so25036855qta.1; Tue, 08 Oct 2019 05:38:27 -0700 (PDT) X-Gm-Message-State: APjAAAWy7yPA/NtOvpSA6JR3NprGx8Az19d2KJ7yNuGjuPzyDXqjvnis K4kBX5jtWvt8+jEEf+4j0OI9GPFAKm8BTMhU1w== X-Received: by 2002:ac8:6982:: with SMTP id o2mr35571093qtq.143.1570538306332; Tue, 08 Oct 2019 05:38:26 -0700 (PDT) MIME-Version: 1.0 References: <20191004151414.8458-1-krzk@kernel.org> In-Reply-To: <20191004151414.8458-1-krzk@kernel.org> From: Rob Herring Date: Tue, 8 Oct 2019 07:38:14 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU To: Krzysztof Kozlowski Cc: Kukjin Kim , Mark Rutland , David Airlie , Daniel Vetter , Lee Jones , Greg Kroah-Hartman , Maciej Falkowski , Marek Szyprowski , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-samsung-soc , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel , "open list:SERIAL DRIVERS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > The clkoutN names of clocks must be unique because they represent > unique inputs of clock multiplexer. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > index 73b56fc5bf58..d8e03716f5d2 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > @@ -53,8 +53,10 @@ properties: > List of clock names for particular CLKOUT mux inputs > minItems: 1 > maxItems: 32 > - items: > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > + allOf: > + - items: > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > + - uniqueItems: true You shouldn't need the 'allOf', just add uniqueItems at the same level as items. Rob