Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Oct 2019 15:08:03 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     Qian Cai <cai@lca.pw>
Cc:     sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
        peterz@infradead.org, mhocko@kernel.org, linux-mm@kvack.org,
        john.ogness@linutronix.de, akpm@linux-foundation.org,
        david@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()
Message-ID: <20191008130803.jf3xdtyt3qpfotn5@pathway.suse.cz>
References: <1570228005-24979-1-git-send-email-cai@lca.pw>
 <20191007143002.l37bt2lzqtnqjqxu@pathway.suse.cz>
 <1570460350.5576.290.camel@lca.pw>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1570460350.5576.290.camel@lca.pw>
User-Agent: NeoMutt/20170912 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon 2019-10-07 10:59:10, Qian Cai wrote:
> It is almost impossible to eliminate all the indirect call chains from
> console_sem/console_owner_lock to zone->lock because it is too normal that
> something later needs to allocate some memory dynamically, so as long as it
> directly call printk() with zone->lock held, it will be in trouble.

It is not normal the something needs to allocate memory under
console_sem. Console drivers are supposed to get the message
out even when the system is in really bad state and it is not
possible to allocate memory. I consider this a bug in the console
driver.

> I really hope the new printk() will solve this class of the problem, but it is
> essentially up to the air until a patchset was posted. There are just too many
> questions out there to be answered.

The new printk should prevent all deadlocks simply because it will
be fully lockless. The console drivers will be called from dedicated
kthreads and therefore from a well defined context.

Best Regards,
Petr