Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbWAEGWL (ORCPT ); Thu, 5 Jan 2006 01:22:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752023AbWAEGWK (ORCPT ); Thu, 5 Jan 2006 01:22:10 -0500 Received: from mx1.redhat.com ([66.187.233.31]:63156 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1752022AbWAEGWJ (ORCPT ); Thu, 5 Jan 2006 01:22:09 -0500 Date: Thu, 5 Jan 2006 01:22:08 -0500 From: Dave Jones To: linux-kernel@vger.kernel.org Subject: dual line backtraces for i386. Message-ID: <20060105062208.GA12095@redhat.com> Mail-Followup-To: Dave Jones , linux-kernel@vger.kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1261 Lines: 43 Another 'get better debug info from users' patch. x86-64 has had this since day one, and I don't know why no-one ever ported it to i386. Instead of using one line per function call in the backtrace, we can fit two per line. Signed-off-by: Dave Jones --- linux-2.6.15/arch/i386/kernel/traps.c~ 2005-12-01 04:25:36.000000000 -0500 +++ linux-2.6.15/arch/i386/kernel/traps.c 2005-12-01 04:36:19.000000000 -0500 @@ -116,6 +116,7 @@ static inline unsigned long print_contex unsigned long *stack, unsigned long ebp) { unsigned long addr; + char space=0; #ifdef CONFIG_FRAME_POINTER while (valid_stack_ptr(tinfo, (void *)ebp)) { @@ -131,9 +132,17 @@ static inline unsigned long print_contex if (__kernel_text_address(addr)) { printk(" [<%08lx>]", addr); print_symbol(" %s", addr); - printk("\n"); + if (space == 0) { + printk(" "); + space = 1; + } else { + printk("\n"); + space = 0; + } } } + if (space==1) + printk("\n"); #endif return ebp; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/