Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbWAEGln (ORCPT ); Thu, 5 Jan 2006 01:41:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752066AbWAEGln (ORCPT ); Thu, 5 Jan 2006 01:41:43 -0500 Received: from liaag2ac.mx.compuserve.com ([149.174.40.152]:52170 "EHLO liaag2ac.mx.compuserve.com") by vger.kernel.org with ESMTP id S1752067AbWAEGln (ORCPT ); Thu, 5 Jan 2006 01:41:43 -0500 Date: Thu, 5 Jan 2006 01:38:32 -0500 From: Chuck Ebbert <76306.1226@compuserve.com> Subject: Re: [patch 2.6.15] i386: Optimize local APIC timer interrupt code To: Willy Tarreau Cc: Linus Torvalds , Andrew Morton , linux-kernel Message-ID: <200601050141_MC3-1-B553-82B6@compuserve.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 23 In-Reply-To: <20060105060314.GB7142@w.ods.org> On Thu, 5 Jan 2006 at 07:03:14 +0100, Willy Tarreau wrote: > + if (likely(--per_cpu(prof_counter, cpu)) <= 0) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ are you sure about this ? it looks suspicious to me. I would have expected something like this instead : + if (likely(--per_cpu(prof_counter, cpu) <= 0)) { Nice catch, proving yet again the value of posting code for review! -- Chuck Currently reading: _Thud!_ by Terry Pratchett - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/