Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5747807ybp; Tue, 8 Oct 2019 07:44:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQzpjHbPGu3Lnxvgqpnyilsp4UMVVTGngg91lK/dtMJtSMuqUTCsYAqkjSgOnz3Paf3spS X-Received: by 2002:a17:906:4a17:: with SMTP id w23mr20533307eju.324.1570545857984; Tue, 08 Oct 2019 07:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570545857; cv=none; d=google.com; s=arc-20160816; b=hYZ0FBiRXPdD4bQjDCGqfgC8MncS07W9VZUz3jj7LxDcRDaTdo50c+xJjlp7v+6fV0 GnD3sJcdUVXun12JDbXGlARBdCbRjZTFgS0cabtMEJZvyQE5F5tBKGIzTtVZfOJCZIZE Vo9cuPSFYSu9xbWVKznIVzixLl6nf9qdGsCDpaqbgeW/zsRMn7XfAR6b0krvtZLLg4fh xeKw/HypHG6pz1WRZhfyaNiQo/WFJHChQQMhcxlZLfaTSSgb5tP0m6VC/E84rMVSearB FQx6E4yspPfd/OKzLGzurdPJfnPYvSeWKguJC1ms2Okl59bMTPS0LkcEin02sbU8sCox KRKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=xyKOCzt1B/yZOU7EZG+vJuZWXCAgr6nCg8pL057Tl80=; b=JXm5OxH6JjVTy9c7F6CMtzJL2vzUJ7x325BLj0mekfkulgW/x0W8Oz+VsqVknm50Uj RD4qGeGftNIXMcnieqkBIjibt0A7kAbXPuyhO0YbSXp4vhr/aS6M0KvCJDHtBeIy2Tgh 08hrjcyKWJJKb2pp6hJ9CY8DWd/Az8Zk4fMcuPuDfY8aaK8UCUgfoU/Cc+aSQ0CYUvEE l4+QYuiFFO0iWRW7GU4GZcHb0VxrszplDdyp1wcqNL/LUSxbe2mRYnYXTRjXhTMy7vIw 8OAziaIV8/oV+Xu4D2QGzTtcyubcV13EpJuImwoT4rTWuHKukSJ5o2zOGMKjHOYHqZjp VcSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ov32si2958638ejb.411.2019.10.08.07.43.54; Tue, 08 Oct 2019 07:44:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbfJHOni (ORCPT + 99 others); Tue, 8 Oct 2019 10:43:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:59640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfJHOni (ORCPT ); Tue, 8 Oct 2019 10:43:38 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E998520659; Tue, 8 Oct 2019 14:43:36 +0000 (UTC) Date: Tue, 8 Oct 2019 10:43:35 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com, torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, namit@vmware.com, hpa@zytor.com, luto@kernel.org, ard.biesheuvel@linaro.org, jpoimboe@redhat.com Subject: Re: [PATCH v3 5/6] x86/ftrace: Use text_poke() Message-ID: <20191008104335.6fcd78c9@gandalf.local.home> In-Reply-To: <20191007081945.10951536.8@infradead.org> References: <20191007081716.07616230.8@infradead.org> <20191007081945.10951536.8@infradead.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Oct 2019 10:17:21 +0200 Peter Zijlstra wrote: > Move ftrace over to using the generic x86 text_poke functions; this > avoids having a second/different copy of that code around. > > This also avoids ftrace violating the (new) W^X rule and avoids > fragmenting the kernel text page-tables, due to no longer having to > toggle them RW. > > Cc: Steven Rostedt > Cc: Daniel Bristot de Oliveira > Signed-off-by: Peter Zijlstra (Intel) > --- BTW, I'd really like to take this patch series through my tree. That way I can really hammer it, as well as I have code that will be built on top of it. I'll review the other series in this thread, but I'm assuming they don't rely on this series? Or do they? -- Steve