Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Oct 2019 14:29:46 +0000
From:   Dan Robertson <dan@dlrobertson.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: (bma400) add driver for the BMA400
Message-ID: <20191008142946.GA7784@nessie>
References: <20190925013941.20431-1-dan@dlrobertson.com>
 <20190925013941.20431-2-dan@dlrobertson.com>
 <20191006093754.61a12172@archlinux>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd"
Content-Disposition: inline
In-Reply-To: <20191006093754.61a12172@archlinux>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--vkogqOf2sHV7VnPd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Jonathan,

Thanks for the review! I _think_ I've made all the changes you mentioned
locally. I'll run some more tests and clean it up a bit before submitting the
next patchset version.

> So my first thought was that Bosch have been moderately good at keeping their
> interfaces consistent across generations.  Seems not this time from
> a quick look!

Originally I had hoped to extend the bma180 driver, but there did seem to be a
reasonably large change in the interfaces. I also hope to add support for some
of the newer features and SPI. I think it would be possible to merge the two
drivers, but I think it would require pretty close to a complete overhaul of
the bma180 driver. If this is something you'd like to explore, I can probably
order a breakout board for the BMA180 and BMA220 and work on a way to create a
driver that supports all three.

> I'd also expect a modern driver to have DT bindings.  Might let that go if
> it was being used with ACPI but neither is true here.

Good catch. The DT bindings will be very simple in the initial version of the
driver. I'll add the bindings and some documentation.

> See the docs for struct iio_info -> read_avail.

Nice! I missed this. This fits exactly what I needed.

Cheers,

Dan

--vkogqOf2sHV7VnPd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEF5dO2RaKc5C+SCJ9RcSmUsR+QqUFAl2cnVUACgkQRcSmUsR+
QqXyLA//eu9Q/gGMKF3BqJN9CTa7BhBQaCeEjUJ9R9mD79eaF7uOXJ+wgUZwSFtk
0VtFigIzrigNGiZX4h21kqGf5zKaYUEgQZXaA4UbRgEwDVGQXqe2p4SidEWRh90K
KcD/AO4fh3DlXipMH7ZkAzfLDPnHqf27b0W759prlrgYYIYSjZUIk9YKoIVSHFlJ
i8h6/nsvqMWMeGM7z1W4ZPU3KmSM9jr+mZXPKgdooan2cAKk0FuZwQSLXhnRDi8F
55MaT1Syr9BwOKTDX8K4h4K9UOwo7cFPqo24Ihwa1vDT2bQLK8e4T8K/GbcybfQd
cAvI5VOdS3f88DF0cGHNMrPLd25yzahu5SINI7oAqrUtXhKsoxg06AFR4R3UtH+u
uYtQ37aqbz11awHmA9rJ5MSvoTv6KrA8wsEwu/gk+QGM6Hu5RBX1lCLcGCeNt766
yfk88E6PtLkEofn1Mggeb+m3+jEHNl2ezy/jFjY2hytn269A0INgfWIz1YeEsmx1
JJT8MnJvYRWG9X9Sumcss6ExnNqRY6XDtaS/iGQoeS53r+yDjezwdoKhmuFpsnXu
l2ObWLSmoUN/S/E8jjoo8jWYlgfvB2IBl9P5krUq1U3ZI74DT0Ziwa9GsjwbtM2J
8JXOFHYJXOAXfOaGsvzfgYC4ZK0UBr7fK9hLvud9r2bDJXn+o+4=
=hT/h
-----END PGP SIGNATURE-----

--vkogqOf2sHV7VnPd--