Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5789095ybp; Tue, 8 Oct 2019 08:19:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqyJnWma2Qaf5xQAq68BZxtUEIjEmtUwULmJLgCtDvcwb26XtQdlKowFtmC0H8HZLdcUS4v2 X-Received: by 2002:a17:906:5284:: with SMTP id c4mr29228874ejm.39.1570547978475; Tue, 08 Oct 2019 08:19:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570547978; cv=none; d=google.com; s=arc-20160816; b=KkOA6ay2hXJJyLgvvw/WjfQ9xHIMqSzQz4CgfbImNTzVRGCnNO8/U81Mx2W+0G85uc ZYCD488RmNlAr5uMb3eoq32d+yvoW0IGB2ZHpn762V7J9WBWkJPxxEWNPdhtR68zWZFQ yA1u1MJUYV3VUowFDA0s8iKydYUxOSal8BKfEKiZhkowwo42pGHFBLrjtotpW37EoO6j ZGPESCzBuiixpAcZGn5ce8jUUj+fD7Mq1SipbLnk5dRWr6L5fDmCv/1OZi6/lWpBHHub m1qr6mdsn7cQMZBqmAGyDHMAXtcGdd1nKYTRX/IHzzXuanQ7uCTuTg6CWn3d9W4fy31e dGUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=HBPyM3fbQmTRXscejMZaaT3oltRHFHQ/AKn9AwmsNPM=; b=B++NF6OZHm33l5e91gJRxde96+NE2o8UiABnL5QtSWCBYAhegIv2hOEkCLGLgMOYQM xsckb3HlzGVUSqxsVrXOZXx7HSLO9RFJOLAAEeNGDct6s5am5DA6+wCH+VlCkbMs+ed5 s+It5FkKz0FAYbQIdDVyQ93K6ysdM3v0WcJs1pycGvX9vPGdWzJhjKsLeNsgHWuxTBil bXTmUAwY6I+A9WjZ1l3mmIwoxJ9Ld+I8eFaXJZw/i7igejefT5ipKEdhL0kdq6DakkZN GBxOro/neQpPHsMX7+6/S8BqOtX/kYvaZSGj9WKQPgAJWydfC3KOCP70DdxcCIkCq5Ec WbEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e50si12264170edb.177.2019.10.08.08.19.14; Tue, 08 Oct 2019 08:19:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbfJHPQb (ORCPT + 99 others); Tue, 8 Oct 2019 11:16:31 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:47048 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbfJHPQb (ORCPT ); Tue, 8 Oct 2019 11:16:31 -0400 Received: by mail-pg1-f196.google.com with SMTP id b8so4058768pgm.13 for ; Tue, 08 Oct 2019 08:16:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HBPyM3fbQmTRXscejMZaaT3oltRHFHQ/AKn9AwmsNPM=; b=RDQDDpTGcJ+CU5oG20pFY3+f/912vgZHPuOBlJgUk1GvQDsUpfZWJBhtrPPKHGfKin c5AdPIUJyuSFtv4Ck3+oddWe8kHzE2HPZDNDS+7KJmU8uLuldtt7ZDdvCtovD0E8VbrN btPCwrL3cx9q+KOhIImmLCHtb+dFYgRngz/lyeNtpz0fdmTtEbdk7+Fz3SCLciVUP8iF FOMIIRUR+k/RWlUzyE/tzCGnpQtp9VJl/Vx/3M0b8oGasvTFtiehokX7qML5vIXF4rc5 4aa50AzB2ptrVVEy6mvF0FrXSQg268RXPTed+3GNECqZM2flg+XDeq16K0Nqpm/XlsWf +KjA== X-Gm-Message-State: APjAAAX0c8biphVW0Rpa9j8l9hLOVy4CF9wLPEdY5faNGKTGRdUzdxhd Sgx+OpiwKwkjVNPpXDxeu6lpbGmmIKg= X-Received: by 2002:a17:90a:8001:: with SMTP id b1mr6336570pjn.10.1570547790809; Tue, 08 Oct 2019 08:16:30 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id e21sm13287017pgk.57.2019.10.08.08.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 08:16:29 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id D3FE140255; Tue, 8 Oct 2019 15:16:28 +0000 (UTC) Date: Tue, 8 Oct 2019 15:16:28 +0000 From: Luis Chamberlain To: Tuowen Zhao Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, acelan.kao@canonical.com, bhelgaas@google.com, kai.heng.feng@canonical.com Subject: Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Message-ID: <20191008151628.GA16384@42.do-not-panic.com> References: <20191007184231.13256-1-ztuowen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007184231.13256-1-ztuowen@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote: > +EXPORT_SYMBOL(devm_ioremap_uc); EXPORT_SYMBOL_GPL() would be my preference. Luis