Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5852749ybp; Tue, 8 Oct 2019 09:14:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6T5b9H2vdWw0bf+3L9S4ze3GUrRxnKHvwLwSBJDZFgynDUncH2kDH9TlbzoJUc299BWGD X-Received: by 2002:a50:ed8e:: with SMTP id h14mr34653796edr.69.1570551247729; Tue, 08 Oct 2019 09:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570551247; cv=none; d=google.com; s=arc-20160816; b=UHi72y5fXtqhfWXywZ271RnRPV39B6dUxO8tCw6xJdm1a3Kp6sN2e+R9539PZUGbzA i07LpbjgvqJPIZjWlR0Nm45ojiYWAloSFNwOw5cVY71R0yF06r7vNk8hrOJIC24I8EWk K0Yh4tlXzqEFA0S4QzHYQwPq0dAHsEzrrX8JqtJjZLLMQrQJbpE8ZgxbUUwB40mSqe1S v2z2z4YtaQosQIxxAAjCqaABBS/LpriMcUaMlkKS5EXR0X+C7XbsmBasNmz+UsXWk37J nqN2Kv6w9rG4WtjPsc1vlTlJfplvGjQsaUEBqgE0M3iFdy55JJ+Oqh/VPEcsuGWbQT1s q4Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hdYDTZKkeH8RsIylRCO8PQnA+A1ZxiFwFKjT7GPkCUs=; b=tfERlmfyZCFoQsmEAsKQaSWkhcu96JDrIDGZeD9j/NLE6Gg5LbVpnMGJ06aeKz9cpM 6ljnM7CLps1HHikESQHAkCA8WwSoYzH2tMrnZoejcgbXQvzsm6NDWWnDtkDT+NKS3gNW KsMYPEXyfLSOr8NiPrpJyetuPAdaY10Kt0YcrkaCFtU3pdsFPFLM9smSHYm+48NVcfhC 4H0H3OU/qo5Vrof9NnRICsY4Ofo1NfROlq5FAlmF1+CdH5qbbdnqv1A9Jr10S+iYJwLM 1oPFX0TWlFOtZUMjtXduEWdH0/4UaFiIcng4Z/5eLhGw6ELRU/4rQ3ycfFYjBLG8Tv8U /j3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x47si11207443eda.396.2019.10.08.09.13.43; Tue, 08 Oct 2019 09:14:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727514AbfJHQMt (ORCPT + 99 others); Tue, 8 Oct 2019 12:12:49 -0400 Received: from mga04.intel.com ([192.55.52.120]:42615 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfJHQMt (ORCPT ); Tue, 8 Oct 2019 12:12:49 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 09:12:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="206667983" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 08 Oct 2019 09:12:47 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iHs6P-0003r1-Mi; Tue, 08 Oct 2019 19:12:45 +0300 Date: Tue, 8 Oct 2019 19:12:45 +0300 From: Andy Shevchenko To: Luis Chamberlain Cc: Tuowen Zhao , lee.jones@linaro.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, acelan.kao@canonical.com, bhelgaas@google.com, kai.heng.feng@canonical.com Subject: Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Message-ID: <20191008161245.GU32742@smile.fi.intel.com> References: <20191007184231.13256-1-ztuowen@gmail.com> <20191008151628.GA16384@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008151628.GA16384@42.do-not-panic.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 08, 2019 at 03:16:28PM +0000, Luis Chamberlain wrote: > On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote: > > +EXPORT_SYMBOL(devm_ioremap_uc); > > EXPORT_SYMBOL_GPL() would be my preference. Maybe we can even split this to two patches? -- With Best Regards, Andy Shevchenko