Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 1/1] blk-mq: fill header with kernel-doc
To:     Gabriel Krisman Bertazi <krisman@collabora.com>,
        =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@collabora.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        axboe@kernel.dk, kernel@collabora.com
References: <20191008001416.12656-1-andrealmeid@collabora.com>
 <854l0j19go.fsf@collabora.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <6aa48cd2-5f23-a4be-f777-d65bf755a976@acm.org>
Date:   Tue, 8 Oct 2019 10:30:58 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <854l0j19go.fsf@collabora.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/8/19 9:35 AM, Gabriel Krisman Bertazi wrote:
> André Almeida <andrealmeid@collabora.com> writes:
> 
>> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
>> index e0fce93ac127..8b745f229789 100644
>> --- a/include/linux/blk-mq.h
>> +++ b/include/linux/blk-mq.h
>> @@ -10,74 +10,153 @@ struct blk_mq_tags;
>>   struct blk_flush_queue;
>>   
>>   /**
>> - * struct blk_mq_hw_ctx - State for a hardware queue facing the hardware block device
>> + * struct blk_mq_hw_ctx - State for a hardware queue facing the hardware
>> + * block device
>>    */
>>   struct blk_mq_hw_ctx {
>>   	struct {
>> +		/** @lock: Lock for accessing dispatch queue */
>>   		spinlock_t		lock;
>> +		/**
>> +		 * @dispatch: Queue of dispatched requests, waiting for
>> +		 * workers to send them to the hardware.
>> +		 */
> 
> It's been a few years since I looked at the block layer, but isn't
> this used to hold requests that were taken from the blk_mq_ctx,  but
> couldn't be dispatched because the queue was full?

I don't think so. I think that you are looking for the requeue_list 
member of struct request_queue.

Bart.