Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Oct 2019 19:06:57 +0000 (UTC)
From:   Christopher Lameter <cl@linux.com>
To:     Kaitao Cheng <pilgrimtao@gmail.com>
cc:     akpm@linux-foundation.org, sashal@kernel.org, mhocko@suse.com,
        osalvador@suse.de, mgorman@techsingularity.net, rppt@linux.ibm.com,
        dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com,
        pavel.tatashin@microsoft.com, glider@google.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Muchun Song <smuchun@gmail.com>
Subject: Re: [PATCH] mm, page_alloc: drop pointless static qualifier in
 build_zonelists()
In-Reply-To: <20190927161416.62293-1-pilgrimtao@gmail.com>
Message-ID: <alpine.DEB.2.21.1910081906120.4398@www.lameter.com>
References: <20190927161416.62293-1-pilgrimtao@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 28 Sep 2019, Kaitao Cheng wrote:

> There is no need to make the 'node_order' variable static
> since new value always be assigned before use it.

In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large
array allocations on the stack are problematic.

Maybe that is no longer the case?