Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Oct 2019 12:14:57 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     "Maciej W. Rozycki" <macro@linux-mips.org>,
        Colin King <colin.king@canonical.com>
Cc:     "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] netdevsim: fix spelling mistake "forbidded" ->
 "forbid"
Message-ID: <20191008121457.34b570be@cakuba.netronome.com>
In-Reply-To: <alpine.LFD.2.21.1910080921350.25653@eddie.linux-mips.org>
References: <20191008081747.19431-1-colin.king@canonical.com>
        <alpine.LFD.2.21.1910080921350.25653@eddie.linux-mips.org>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 8 Oct 2019 09:29:58 +0100 (BST), Maciej W. Rozycki wrote:
> On Tue, 8 Oct 2019, Colin King wrote:
> 
> > diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> > index a3d7d39f231a..ff6ced5487b6 100644
> > --- a/drivers/net/netdevsim/dev.c
> > +++ b/drivers/net/netdevsim/dev.c
> > @@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
> >  		/* For testing purposes, user set debugfs dont_allow_reload
> >  		 * value to true. So forbid it.
> >  		 */
> > -		NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
> > +		NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");  
> 
>  If nitpicking about grammar, then FWIW I believe it should actually be:
> 
> 		NL_SET_ERR_MSG_MOD(extack, "User forbade the reload for testing purposes");
> 
> (and then:
> 
> 		NL_SET_ERR_MSG_MOD(extack, "User set up the reload to fail for testing purposes");
> 
> elsewhere).

So I consulted with someone vaguely British, and they said they'd use
"forbid" here, therefore I've applied the patch to net-next.