Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Oct 2019 12:51:02 -0700 (PDT)
From:   Hugh Dickins <hughd@google.com>
To:     Ian Kent <raven@themaw.net>, Karel Zak <kzak@redhat.com>
cc:     Hugh Dickins <hughd@google.com>, Laura Abbott <labbott@redhat.com>,
        David Howells <dhowells@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Linux-MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org
Subject: Re: mount on tmpfs failing to parse context option
In-Reply-To: <20191008125610.s4fgnnba7yhclb3z@10.255.255.10>
Message-ID: <alpine.LSU.2.11.1910081219210.1204@eggly.anvils>
References: <d5b67332-57b7-c19a-0462-f84d07ef1a16@redhat.com> <d7f83334-d731-b892-ee49-1065d64a4887@redhat.com> <alpine.LSU.2.11.1910071655060.4431@eggly.anvils> <59784f8ac4d458a09d40706b554432b283083938.camel@themaw.net>
 <20191008125610.s4fgnnba7yhclb3z@10.255.255.10>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="0-1683574798-1570564286=:1204"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-1683574798-1570564286=:1204
Content-Type: TEXT/PLAIN; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Tue, 8 Oct 2019, Karel Zak wrote:
> On Tue, Oct 08, 2019 at 08:38:18PM +0800, Ian Kent wrote:
> > > That's because the options in shmem_parse_options() are
> > > "size=3D4G,nr_inodes=3D0", which indeed looks like an attempt to
> > > retroactively limit size; but the user never asked "size=3D4G" there.
> >=20
> > I believe that's mount(8) doing that.
> > I don't think it's specific to the new mount api.
> >=20
> > AFAIK it's not new but it does mean the that things that come
> > through that have been found in mtab by mount(8) need to be
> > checked against the current value before failing or ignored if
> > changing them is not allowed.
> >=20
> > I wonder if the problem has been present for quite a while but
> > gone unnoticed perhaps.
> >=20
> > IIUC the order should always be command line options last and it
> > must be that way to honour the last specified option takes
> > precedence convention.
> >=20
> > I thought this was well known, but maybe I'm wrong ... and TBH
> > I wasn't aware of it until recently myself.
>=20
> Yep, the common behavior is "the last option wins". See man mount,
> remount option:
>=20
>   remount  functionality  follows  the standard way the mount command
>   works with options from fstab.  This means that mount does not read
>   fstab (or mtab) only when both device and dir are specified.
>=20
>         mount -o remount,rw /dev/foo /dir
>=20
>   After this call all old mount options are replaced and arbitrary
>   stuff from fstab (or mtab) is ignored, except the loop=3D option which
>   is  internally  generated  and  maintained by the mount command.
>=20
>         mount -o remount,rw  /dir
>=20
>   After  this call, mount reads fstab and merges these options with
>   the options from the command line (-o).  If no mountpoint is found
>   in fstab, then a remount with unspeci=E2=80=90 fied source is allowed.
>=20
>=20
> If you do not like this classic behavior than recent mount(8) versions
> provide --options-mode=3D{ignore,append,prepend,replace} to keep it in
> your hands.

Ian, Karel, many thanks for your very helpful education.
I've not yet digested all of it, but the important thing is...

Yes, you're right: my unexpectedly failing remount sequence fails
equally on a v5.3 kernel, and I'll hazard a guess that it has failed
like that ever since v2.4.8.  I just never noticed (and nobody else
ever complained) until I tried testing the new mount API: which at
least has the courtesy to put an error message reflecting the final
decision in dmesg, when the older kernels just silently EINVALed.

(And it's not impossible to remount thereafter: one just has to add
a "size=3D0" into the options, to allow the other options through.)

So, I've no more worries for v5.4 tmpfs mount, and if there's anything
that can be improved, that's a background job for me to look into later,
once I've spent more time understanding the info you've given me.

And Laura has confirmed that Al's security_sb_eat_lsm_opts() patch
fixes the "context" issue: thanks.

Hugh
--0-1683574798-1570564286=:1204--