Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp66079ybp; Tue, 8 Oct 2019 14:09:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqzpOsC+K6jQPH/aXjlwo7l6dgddDOlc+ccDQzMp9zC/L4YAKm2bf5NaPG1nX/WZN13TePIr X-Received: by 2002:a17:906:80c3:: with SMTP id a3mr30409171ejx.271.1570568946361; Tue, 08 Oct 2019 14:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570568946; cv=none; d=google.com; s=arc-20160816; b=bzHcRx6bwJQzpc8FjBCg8qF3R4TqzanM5QCnY2yL5vgmXcFeLtHUbEipr+VyT9dzvK hNXynqr9UKgl4w2r4OmeQkZJxWh2Udw/5H54NtF26VuHh7H4BDUAaOQShrtzNpUcLP9l uPdv1reI/oorUBoyBsdpML9ZQiCGy4NAQt9Lzr1Or17MgavT0DW02IbtEAkgpuq6oNNN JujKltmUSOTHA0HpP3Ia2GNBr/kROAVICLBBfBCq/EdNBI1QvTJmUN9gv5xooV2+1Qh4 P0M3lOEL60kCQQOBLGFQ51Atu0vIMTpGJSAjl8kc92iRVYko0NLfBYOipKIae3l3Jq1C cVjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=3OUODisVOD2eZGqSrDXRITR9cL9jsCAanTmMcFWhJrU=; b=Xi29UpTyObSE9yZsPfMC2FJtGKpu77jU4txBs+qB+kG0n7YeLGNKv+zzmsMJNa3Nvn hXKcRf+L47UPlcKPwUVG/KDii4yWZ4/tDCnOieSXKXAIpAZmvqDIsMEI3AEyUxtI9JSZ NYHvzZpQWanxejq33vn1otPxLv+m68U5auLi1MkgAmmQS8iTIIju2X80OJFhy9Xx72P1 uihts0nDgT7dSLK9c/3KB0PxaFvZRImfasxZX5D3eCuSepAT/PZ+oxjSTaTANYtKDzo9 hioXHl6R/o8oDdFrELGOEuKhARIcVFz6xRIB+cTldYlI/6VHjn7kGW3lb6Q8wxasBLWs dRww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="P5rO/Dlj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g37si129074edg.59.2019.10.08.14.08.42; Tue, 08 Oct 2019 14:09:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="P5rO/Dlj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730988AbfJHVHU (ORCPT + 99 others); Tue, 8 Oct 2019 17:07:20 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43134 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730523AbfJHVHU (ORCPT ); Tue, 8 Oct 2019 17:07:20 -0400 Received: by mail-pl1-f194.google.com with SMTP id f21so8995412plj.10 for ; Tue, 08 Oct 2019 14:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=3OUODisVOD2eZGqSrDXRITR9cL9jsCAanTmMcFWhJrU=; b=P5rO/Dljz6qsI4BairQeeF9R/FvzoNkXANU/VCuEqWLNU7hhL2tM0QGLTAczyw9L1+ RrCpoSwkocV3QZyCXfhki800QnYOe6JLbH5rebMsK+DY/XTiAmU1zP3DYem2jWfZjomd jwLCvWQfD4Uwuee2V70OpUsCf3JSy0vbl9fmywFr0nrcHeBPqL0dpoRlRUhU1yz4y5ap Om7ty9T0UTideRDCggYz/MfflfRZ1wLgrMCm5m/d5nfxGzXkHd3Z3wESuCC3XT0iRp75 wE/0Jb4R0GlM4Uejv1cl/lBlP8AOSHGaXmLJpwRQDKeOhRNkdJ5cV6ZCyGRstaFS4B8R Zaeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=3OUODisVOD2eZGqSrDXRITR9cL9jsCAanTmMcFWhJrU=; b=SGICbcubB7FJP1cOSf9YAW937FLw4GqxR7hKEK0k+zqc85iwIGBLx1otkWjvxLFUI5 ToCj6paV9ZYcy8nYhv8dwU+KAVhCYHI18fPVZhw0qNFgqnBIt/Ku/y/QFwNIbSOOOah0 QYScs0m0kItWvVFrSNBONNTZ9iiVjmE0BC7XqNzOaxzlIk2Zk0Dj2pyTzYRInZQd+xrA T9nYNejWzZs6CqfBSiowgweRJAIaDUCxF4d6G4EqOF+lqwd7TxB4xYFRLEh1NXuuRdBD TG94i6HIdRKvsxpFsJZ7DrupBj1AwZ+OHKMiYYCHtb48xz0n8wAiBBm+0OsF2DaA/uLd CJPA== X-Gm-Message-State: APjAAAX05RLZ8qPuR0xzMcvTWqloWEHn3FAUInNuUg1jgs6ksnq80CS9 rBkxl4BZOt8yVGnwm+kupEo= X-Received: by 2002:a17:902:36c:: with SMTP id 99mr36251113pld.69.1570568839342; Tue, 08 Oct 2019 14:07:19 -0700 (PDT) Received: from iclxps ([155.98.131.7]) by smtp.gmail.com with ESMTPSA id b3sm93467pjp.13.2019.10.08.14.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 14:07:18 -0700 (PDT) Message-ID: <56c3808b29838ff37852e196184a7b995f5f1336.camel@gmail.com> Subject: Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO From: GMAIL To: Luis Chamberlain , Andy Shevchenko Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, acelan.kao@canonical.com, bhelgaas@google.com, kai.heng.feng@canonical.com Date: Tue, 08 Oct 2019 15:07:16 -0600 In-Reply-To: References: <20191007184231.13256-1-ztuowen@gmail.com> <20191008151628.GA16384@42.do-not-panic.com> <20191008161245.GU32742@smile.fi.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I think that's a fair point. Sorry for not noticing it earlier. > On Tue, Oct 8, 2019, 6:12 PM Andy Shevchenko < > andriy.shevchenko@linux.intel.com> wrote: > > Maybe we can even split this to two patches? I assume splitting means one to add devm_ioremap_uc and one to use it for intel-lpss-pci. Tuowen