Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp171064ybp; Tue, 8 Oct 2019 16:03:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJWGBnogr9WRFX6hm0vUzruz6XuSwlLVYH+vvvGUcK52MgRNEHW8r6+xHJTuiVU9SGsFyT X-Received: by 2002:a17:906:cd11:: with SMTP id oz17mr119315ejb.71.1570575812081; Tue, 08 Oct 2019 16:03:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570575812; cv=none; d=google.com; s=arc-20160816; b=KBlMk9mt5hoXW86+9Ux5yeB1ameATlXAKyzVMMgdLx+752PVZACDb09bM/d3sw0Vic xZ5Jxb8hPmuwDMflaYl8mqm2LvBthlAtBISoXivkgZT5GZ7Y9XaXAafdtvmDIw5tjfu1 rkcSKUk2pZaHNjbF6glOwAm9Sqooq47ihL9S0a26ArPVwexItnv6Pg6id8v5ZdKSjwt+ kF01THIbYIwLbHl/tNcvvJVgQEjLRYbg9XfIeIG0X26HrCkvdtvqcdICtYij2eJkwNme KfFSoj069I2iMMkkDlTnMyVant/PnelepSsIQmUTjVZCuZZ0O75eXqCbBIsrPlv7INi8 GcKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=FMMLRXtAe40zCMcCtxvdP8i9kT/PLF62chlFdNDSpa8=; b=YCq4xl18lW3TwUQVPt2j3rlRy8dt9Fp8hF9tNIek88+AzVLsO01WcUIq9BgXjxJKgY DTLbuIOPeGNW3vvMtkwVrrrve/n8x5dyYmBDfYZydo1Ns11Vs6Dr/skYpyQYo/szlVfb K5q2CEMbOSEgsY4u3N+3193M7bVDd1YJfomsYwDbiwwHDW6syi4aDcYp37dkv73I+90K b6lJSGo7MqeD8fgP/Dn2ZlCLfxK0WYruEdzeTHdERKJzies1JVSJOpBPH8w3xVp4StC/ HsoSU3UzpO4XHOUa3gJogboOrWR9u/qBgen7dOBBgcMQPjAP0OT7p8gcIDrRwj3D1q2v 0DOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=ZFzM3Avg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g40si256885edg.397.2019.10.08.16.03.08; Tue, 08 Oct 2019 16:03:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=ZFzM3Avg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725848AbfJHXCg (ORCPT + 99 others); Tue, 8 Oct 2019 19:02:36 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:37754 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbfJHXCf (ORCPT ); Tue, 8 Oct 2019 19:02:35 -0400 Received: by mail-qk1-f194.google.com with SMTP id u184so473806qkd.4 for ; Tue, 08 Oct 2019 16:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=FMMLRXtAe40zCMcCtxvdP8i9kT/PLF62chlFdNDSpa8=; b=ZFzM3Avgh1nIZ9kRcYhwKQbctGHGKBEN6jhP8dxhduJ+4EPcJfdb2kEs36EGwPKTgY GDu8aQ/hL/5/0pTwv3fuQIb7NEH80mv1qvtHUPcsc7IUlxs5BVnnMg1tTykwNYvNgV8e U6cvjWUrJCi32I4kQ9et1ar15nltNXj7yQLsGBAHP5fONJlcWrRWecoAIR0PCwqx/fah AohsRSAmEUBkgvOT6hpYM+z0EAqfUnvZowytJBkjh18ZY1GnBTSZJ5Jm4uRphbNrAzgv 0249cyY1Six4SoTA371Mti6zSmwExvlG7oCD2Xv9qNzjaPKZVK7C7/2o2RoBWuVuYZO7 CgOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=FMMLRXtAe40zCMcCtxvdP8i9kT/PLF62chlFdNDSpa8=; b=hhz562IfrMm9YXiq5g0EQOqE040VyDLSLKPCQD7/yaN4qlAG4J6iawML7UH+dfPvbp u+xyI5n8vcwL1V2rwzZfeFyMsTP2cdJrTKK7p8oh0Yg85vsi6bw8UCKhrRSDmbYVUeUh /bMTEouoOHSGKhrMWUrSThFk+t78bY9VLuKbnMb0fdqDNKYZTyCwLyU4BHKtH6Ai7uSt 7vQBFx8KK8BoEvO4OHVxfAd/h8mYYBeTDgS6icEkjJarh7nu0yT0wBr9cntczxVavNdt VpJaUeiSGrVH4nnfHRaJCUuwzWINmyyyun3d4Ofcd/iUwllBDCzaDeVmzRSvh2b1nvQu nKpg== X-Gm-Message-State: APjAAAW9EhxMDDxysxBRwszBFotWDtwupEnyPrfTBvpsYpkHqnOJlDd4 NHPvkQysjEoJtrpfMLSU8Gw54w== X-Received: by 2002:a37:a646:: with SMTP id p67mr569346qke.489.1570575754654; Tue, 08 Oct 2019 16:02:34 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id a19sm204875qtc.58.2019.10.08.16.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 16:02:34 -0700 (PDT) Date: Tue, 8 Oct 2019 16:02:22 -0700 From: Jakub Kicinski To: MarkLee Cc: "David S. Miller" , Sean Wang , John Crispin , Nelson Chang , Matthias Brugger , Andrew Lunn , Rob Herring , Mark Rutland , Rene van Dorst , , , , , Subject: Re: [PATCH net,v2 0/2] Update MT7629 to support PHYLINK API Message-ID: <20191008160222.0bdb7f47@cakuba.netronome.com> In-Reply-To: <20191007070844.14212-1-Mark-MC.Lee@mediatek.com> References: <20191007070844.14212-1-Mark-MC.Lee@mediatek.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Oct 2019 15:08:42 +0800, MarkLee wrote: > This patch target to update mt7629 eth driver and dts to support PHYLINK Thanks for the patches Mark. The description of the set should probably say that it _fixes_ some issues. Right now it sounds a little bit like you were adding a new feature. Could you rewrite the cover letter to give us a better idea what issues this patch set is fixing and why those issues occur?